FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix(sanity): preserve Angular 18 template compatibility by osnoser1 · Pull Request #64 · limitless-angular/limitless-angular · GitHub

fix(sanity): preserve Angular 18 template compatibility - #64

Merged
osnoser1 merged 3 commits into
mainfrom
osnoser1/fix-angular-18-template-compat
Jun 14, 2026
Merged

fix(sanity): preserve Angular 18 template compatibility#64
osnoser1 merged 3 commits into
mainfrom
osnoser1/fix-angular-18-template-compat

Conversation

osnoser1 commented Jun 14, 2026
edited
Loading

Copy link
Copy Markdown
Member

PR Checklist

@limitless-angular/sanity declared Angular 18 support, but the published visual-editing entry point included @let syntax that Angular 18.0.x consumers cannot compile.

Closes #

N/A - no linked issue.

What is the new behavior?

The visual editing insert menu and context menu templates now use @if (...; as icon) aliases instead of @let, preserving the rendered icon behavior while keeping the package compatible with the Angular 18 compiler floor promised by the peer dependency range.

The generated Angular compatibility consumer now covers the public Angular component surfaces more deliberately:

  • Portable Text and Sanity image loading remain live runtime smoke checks with Playwright assertions.
  • Preview kit and visual editing exported components are referenced from an inert ng-template, forcing Angular floor consumers to compile/link those component templates without changing runtime smoke behavior.
  • The visual-editing lazy chunk is included in the Angular 18 floor build, so future template syntax regressions in that path should fail compatibility CI.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Testing:

  • rg -n "@let" packages/sanity
  • pnpm --filter @limitless-angular/sanity build
  • pnpm --filter @limitless-angular/sanity test
  • pnpm run compat:pack
  • pnpm run compat:test --set angular-18-floor --skip-runtime
  • node --test tools/angular-compat/*.test.mjs
  • pnpm run compat:test --set angular-18-floor
  • git diff --check

Negative verification:

  • Temporarily reintroduced @let icon = iconFor(schemaType) in VisualEditingInsertMenuComponent, ran pnpm run compat:pack, then confirmed pnpm run compat:test --set angular-18-floor --skip-runtime failed under Angular 18.0.7 with Incomplete block "let icon". The temporary source edit was reverted and the clean artifact was repacked before the final passing run.

Screenshots: N/A - no intended visual change.

[Optional] What gif best describes this PR or how it makes you feel?

netlify Bot commented Jun 14, 2026
edited
Loading

Copy link
Copy Markdown

Deploy Preview for limitless-angular-sanity-example canceled.

Name Link
🔨 Latest commit fce6358
🔍 Latest deploy log https://app.netlify.com/projects/limitless-angular-sanity-example/deploys/6a2f1b3141453d000882a530

pkg-pr-new Bot commented Jun 14, 2026
edited
Loading

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/@limitless-angular/sanity@64

commit: fce6358

osnoser1 merged commit 7b756e1 into main Jun 14, 2026
18 checks passed
osnoser1 deleted the osnoser1/fix-angular-18-template-compat branch June 14, 2026 21:25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant


Back | FazBrowse Home | New Git URL