FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

feat(sanity)!: drop old Sanity dependency majors by osnoser1 · Pull Request #71 · limitless-angular/limitless-angular · GitHub

/ limitless-angular Public

feat(sanity)!: drop old Sanity dependency majors #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
osnoser1 merged 1 commit into from
Jun 16, 2026
Conversation 2 Commits 1 Checks 17 Files changed
Merged

feat(sanity)!: drop old Sanity dependency majors #71

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension .json  (1) .mjs  (1) .ts  (4) .yaml  (1) All 4 file types selected
Only manifest files
Deleted files Viewed files
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Unified
Split
Hide whitespace
Diff view
Unified
Split
Hide whitespace
2 changes: 1 addition & 1 deletion packages/sanity/image-loader/src/index.ts
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
export { provideSanityLoader } from './loader';
export { SanityImage } from './sanity-image.directive';
export type { SanityImageSource } from './types';
export type { SanityImageSource } from '@sanity/image-url';
4 changes: 2 additions & 2 deletions packages/sanity/image-loader/src/loader.ts
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { inject, Provider } from '@angular/core';
import { IMAGE_LOADER, ImageLoaderConfig } from '@angular/common';

import imageUrlBuilder from '@sanity/image-url';
import { createImageUrlBuilder } from '@sanity/image-url';

import {
SANITY_CONFIG,
Expand All @@ -16,7 +16,7 @@ export function sanityImageLoader(config?: SanityConfig | null) {
try {
url = new URL(src);
} catch {
const builder = imageUrlBuilder(config ?? undefined);
const builder = createImageUrlBuilder(config ?? undefined);
url = new URL(builder.image(src).withOptions(options).url());
}

Expand Down
11 changes: 7 additions & 4 deletions packages/sanity/image-loader/src/sanity-image.directive.ts
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -15,16 +15,19 @@ import {
NgOptimizedImage,
} from '@angular/common';

import imageUrlBuilder from '@sanity/image-url';
import { createImageUrlBuilder } from '@sanity/image-url';
import type {
ImageUrlBuilderOptionsWithAliases,
SanityImageSource,
} from '@sanity/image-url';

import {
SANITY_CONFIG,
type SanityConfig,
} from '@limitless-angular/sanity/shared';
import { sanityImageLoader } from './loader';
import type { ImageUrlBuilderOptions, SanityImageSource } from './types';

type LoaderParams = Omit<ImageUrlBuilderOptions, 'quality'>;
type LoaderParams = Omit<ImageUrlBuilderOptionsWithAliases, 'quality'>;

function getNoopImageLoader() {
return (
Expand Down Expand Up @@ -72,7 +75,7 @@ export class SanityImage extends NgOptimizedImage implements OnInit, OnChanges {

private imageUrl = computed(() => {
const url = new URL(
imageUrlBuilder(this.sanityConfig)
createImageUrlBuilder(this.sanityConfig)
.image(this.sanityImage())
.withOptions(this._loaderParams)
.url(),
Expand Down
108 changes: 0 additions & 108 deletions packages/sanity/image-loader/src/types.ts
Show comments
View file
Open in desktop

This file was deleted.

8 changes: 4 additions & 4 deletions packages/sanity/package.json
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
"@angular/common": "^19.0.0 || ^20.0.0 || ^21.0.0",
"@angular/core": "^19.0.0 || ^20.0.0 || ^21.0.0",
"@angular/router": "^19.0.0 || ^20.0.0 || ^21.0.0",
"@sanity/client": "^6.28.0 || ^7.0.0",
"@sanity/client": "^7.0.0",
"rxjs": "^7.8.0"
},
"peerDependenciesMeta": {
Expand All @@ -41,10 +41,10 @@
}
},
"dependencies": {
"@portabletext/toolkit": "^2.0.15 || ^3.0.0 || ^4.0.0 || ^5.0.0",
"@portabletext/types": "^2.0.13 || ^3.0.0 || ^4.0.0",
"@portabletext/toolkit": "^5.0.0",
"@portabletext/types": "^4.0.0",
"@sanity/comlink": "^4.0.1",
"@sanity/image-url": "^1.0.2 || ^2.0.2",
"@sanity/image-url": "^2.0.2",
"@sanity/mutate": "0.18.0",
"@sanity/presentation-comlink": "^2.1.0",
"@sanity/visual-editing": "5.4.3",
Expand Down
6 changes: 3 additions & 3 deletions pnpm-lock.yaml
Show comments
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

20 changes: 20 additions & 0 deletions tools/angular-compat/package-manifest-policy.test.mjs
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,16 @@ const bundledFeatureDependencies = [
'@portabletext/types',
'@sanity/image-url',
];
const supportedSanityDependencyRanges = {
peerDependencies: {
'@sanity/client': '^7.0.0',
},
dependencies: {
'@portabletext/toolkit': '^5.0.0',
'@portabletext/types': '^4.0.0',
'@sanity/image-url': '^2.0.2',
},
};

test('@limitless-angular/sanity keeps framework and client packages peer-owned', () => {
const dependencies = dependencyNames('dependencies');
Expand Down Expand Up @@ -91,6 +101,16 @@ test('@limitless-angular/sanity avoids dependency bucket duplication', () => {
}
});

test('@limitless-angular/sanity only supports current Sanity dependency majors', () => {
for (const [section, ranges] of Object.entries(
supportedSanityDependencyRanges,
)) {
for (const [dependency, range] of Object.entries(ranges)) {
assert.equal(sanityPackageJson[section]?.[dependency], range);
}
}
});

function dependencyNames(section) {
return new Set(Object.keys(sanityPackageJson[section] ?? {}));
}
Loading
Back | FazBrowse Home | New Git URL