FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix(image-loader): update sanity image urls on input changes by osnoser1 · Pull Request #75 · limitless-angular/limitless-angular · GitHub

fix(image-loader): update sanity image urls on input changes - #75

Merged
osnoser1 merged 2 commits into
mainfrom
osnoser1/image-directive-url-inputs
Jun 18, 2026
Merged

fix(image-loader): update sanity image urls on input changes#75
osnoser1 merged 2 commits into
mainfrom
osnoser1/image-directive-url-inputs

Conversation

Copy link
Copy Markdown
Member

PR Checklist

Adds focused coverage and behavior fixes for SanityImage URL generation when inputs that affect the generated Sanity URL change.

Closes #

N/A

What is the new behavior?

  • Exposes inherited ngSrc and loaderParams through directive metadata instead of subclass field redeclarations.
  • Regenerates the synthetic ngSrc when sanityImage, loaderParams, quality, width, or height changes.
  • Filters post-init static NgOptimizedImage input changes after synthesizing ngSrc, so the underlying optimized image directive receives the URL update without throwing for Sanity-specific recomputation.
  • Adds unit tests for the directive input metadata, initial URL generation, Sanity image changes, loader params, quality changes, and dimension changes.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Validation run:

corepack pnpm --filter @limitless-angular/sanity test
corepack pnpm --filter @limitless-angular/sanity build
corepack pnpm --filter @limitless-angular/sanity lint
git diff --check

This PR is stacked on osnoser1/angular-22-support so the Angular 22 migration branch can stay limited to the minimal compatibility workaround.

[Optional] What gif best describes this PR or how it makes you feel?

N/A

Base automatically changed from osnoser1/angular-22-support to main June 18, 2026 01:17
osnoser1 force-pushed the osnoser1/image-directive-url-inputs branch from da4a56b to 4711e9f Compare June 18, 2026 01:20

netlify Bot commented Jun 18, 2026
edited
Loading

Copy link
Copy Markdown

Deploy Preview for limitless-angular-sanity-example canceled.

Name Link
🔨 Latest commit c549313
🔍 Latest deploy log https://app.netlify.com/projects/limitless-angular-sanity-example/deploys/6a3348109055ee00085d5ad4

pkg-pr-new Bot commented Jun 18, 2026
edited
Loading

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/@limitless-angular/sanity@75

commit: c549313

osnoser1 merged commit 1aca302 into main Jun 18, 2026
18 checks passed
osnoser1 deleted the osnoser1/image-directive-url-inputs branch June 18, 2026 01:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant


Back | FazBrowse Home | New Git URL