FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix(sanity): remove lodash-es deep imports by osnoser1 · Pull Request #78 · limitless-angular/limitless-angular · GitHub

fix(sanity): remove lodash-es deep imports - #78

Merged
osnoser1 merged 1 commit into
mainfrom
osnoser1/remove-lodash-es-deep-imports
Jun 20, 2026
Merged

fix(sanity): remove lodash-es deep imports#78
osnoser1 merged 1 commit into
mainfrom
osnoser1/remove-lodash-es-deep-imports

Conversation

Copy link
Copy Markdown
Member

PR Checklist

Closes N/A

What is the new behavior?

  • Removes the direct lodash-es dependency from @limitless-angular/sanity.
  • Replaces preview-kit lodash-es/isEqual deep imports with the existing dequal dependency, so the published FESM no longer ships the extensionless lodash-es/isEqual import that fails in some Vitest/Node-side consumer setups.
  • Replaces portable text lodash memoize usage with a small local memoize helper that preserves the one-argument reference-cache behavior used by the services.
  • Adds regression tests for memoization behavior and live query source-map deep equality.
  • Updates Angular compatibility packaging so it no longer carries @types/lodash-es.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

This fixes a consumer-side Vitest/Node ESM resolution issue caused by the previous extensionless lodash-es/isEqual import in @limitless-angular/sanity/preview-kit.

Testing:

  • pnpm --filter @limitless-angular/sanity test -- portabletext/src/utils/memoize.spec.ts preview-kit/src/live-query-provider/live-queries.service.spec.ts
  • pnpm --filter @limitless-angular/sanity build
  • pnpm --filter @limitless-angular/sanity lint

[Optional] What gif best describes this PR or how it makes you feel?

N/A

netlify Bot commented Jun 20, 2026
edited
Loading

Copy link
Copy Markdown

Deploy Preview for limitless-angular-sanity-example ready!

Name Link
🔨 Latest commit c3d1e03
🔍 Latest deploy log https://app.netlify.com/projects/limitless-angular-sanity-example/deploys/6a36061d2ebfd7000866e353
😎 Deploy Preview https://deploy-preview-78--limitless-angular-sanity-example.netlify.app
📱 Preview on mobile Toggle QR Code...



Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

osnoser1 force-pushed the osnoser1/remove-lodash-es-deep-imports branch from 9018cf3 to c3d1e03 Compare June 20, 2026 03:16

pkg-pr-new Bot commented Jun 20, 2026

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/@limitless-angular/sanity@78

commit: c3d1e03

osnoser1 merged commit 34f65af into main Jun 20, 2026
18 checks passed
osnoser1 deleted the osnoser1/remove-lodash-es-deep-imports branch June 20, 2026 03:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant


Back | FazBrowse Home | New Git URL