feat: write the contacts of twake:contacts:common - #4935
MontaGhanmy wants to merge 5 commits into
Conversation
Sorry, something went wrong.
| if err != nil { | ||
| return nil, err | ||
| } | ||
| if len(members) == 0 || members[0].OrgID == "" { |
There was a problem hiding this comment.
Needs an instance carrying org_domain to find the org_id, otherwise member messages are dropped. Is that right for an organization with no member instance yet?
Sorry, something went wrong.
There was a problem hiding this comment.
The org instance carries org_domain itself: the cloudery sends OrgDomain + OrgID together on create (stack.rb), so it finds itself even with zero members. Only checked the cloudery create path though, not instances created by hand or the data. I'll run a query on stg to be sure.
Sorry, something went wrong.
| family, _ := name["familyName"].(string) | ||
| full = strings.TrimSpace(given + " " + family) | ||
| } | ||
| setOrDelete(c.M, "name", name, len(name) > 0) |
There was a problem hiding this comment.
name is deleted when the card has no components, fullname is kept. Intended?
Sorry, something went wrong.
There was a problem hiding this comment.
Yes, intended. name mirrors the components, fullname the full name. A card with a full name and no components has no name to keep.
Sorry, something went wrong.
| type CommonContactMessage struct { | ||
| Audience struct { | ||
| User string `json:"user"` | ||
| Domain string `json:"domain"` |
There was a problem hiding this comment.
why do we have domain here and don't have an org/tenant id?
Sorry, something went wrong.
There was a problem hiding this comment.
sabre doesn't know about that. at most it knows the domain name guessed from email ( tops ). the rest if from ldap ( hmmm that we can send to sabre from ldap-rest )
Sorry, something went wrong.
There was a problem hiding this comment.
but it should, how then multinancy will be done there and permissions? no, not should, it has to!
Sorry, something went wrong.
|
|
||
| // GetOrgInstanceByOrgDomain retrieves the organization instance of an | ||
| // organization domain, without listing every member instance. | ||
| func GetOrgInstanceByOrgDomain(orgDomain string) (*instance.Instance, error) { |
There was a problem hiding this comment.
and this function already exists in the instance package
but I insist on org_id ) today we have one domain; tomorrow we move to another one ...
Sorry, something went wrong.
There was a problem hiding this comment.
Done, the duplicate is removed and we reuse the existing lookup now;
Sorry, something went wrong.
## Summary - A sharer is trusted for drive auto accept when their instance has the same `OrgID` as the recipient. The sender's instance is read on this stack, so a member hosted elsewhere falls back to domain or contact trust. - Answering a sharing from a member of the same organization writes no contact. Contact trust and `trustedForSharing` stay for people outside the organization. - Behind the `common_contacts` context setting, off by default, and under `auto_accept_trusted` like the other kinds of trust. - `HasCommonContacts` is the same as in #4935, so the two merge cleanly in any order. Part of linagora/twake-workplace-private#1777.
Members go on the organization instance, personal contacts on the instance of their owner. The contact is keyed by its CardDAV path, and a contact written before the feed is taken over by email. Behind the common_contacts context setting, off by default.
Summary