FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Test improvements by akx · Pull Request #316 · lincolnloop/python-qrcode · GitHub

Test improvements - #316

Merged
maribedran merged 25 commits into
lincolnloop:mainfrom
akx:test-improvements
Sep 27, 2024
Merged

Test improvements#316
maribedran merged 25 commits into
lincolnloop:mainfrom
akx:test-improvements

Conversation

akx commented Feb 15, 2023
edited
Loading

Copy link
Copy Markdown
Contributor

This PR (required for #313):

  • refactors tests to split them into more files so they need to be annotated less when PIL is not available
  • rewrites the unittest-style assertions to regular assertions (since pytest is being used to run things)
  • rewrites the unittest-style tests to pytest-style functions (and pytest-style fixtures)
  • parametrizes tests to get rid of redundant code

akx force-pushed the test-improvements branch from 3489991 to c37646f Compare February 15, 2023 15:23
akx marked this pull request as draft February 15, 2023 15:24
akx marked this pull request as ready for review February 16, 2023 18:17
bartTC self-assigned this Aug 13, 2024
bartTC mentioned this pull request Aug 13, 2024

akx commented Sep 26, 2024

Copy link
Copy Markdown
Contributor Author

@maribedran @bartTC I can rebase this cleanly - let me know on what...

Copy link
Copy Markdown
Contributor

Thanks, @akx ! I already merged you changes to #370 .

maribedran merged commit 5405643 into lincolnloop:main Sep 27, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants


Back | FazBrowse Home | New Git URL