Add "svg-compressed" to create a simple classic QR Code with compressed file size. - #407
Add "svg-compressed" to create a simple classic QR Code with compressed file size.#407bartTC wants to merge 18 commits into
Conversation
Sorry, something went wrong.
…er savings by removing M cmds.
…rder to avoid the O(n^2)-ish perf hit for splicing a python list repeatedly. Only store spliceable turns, and assert that we dealt with all of them correctly.
… less readable, but oh well.
Would need to understand the reasoning and implications before putting this to production.
|
Hi @tobiasploetz, thank you for your contribution in #342. Really appreciate your work there! I’ve continued building on it by adding tests and a few additional touches. I noticed the SVG output savings are quite impressive! Around 800 bytes compared to the regular 12 KB version for "Hello". However, I’m curious about the reasoning behind optimizing the SVG size. Since SVGs are typically printed, it seems like file size might not be a major concern, and rather might lead to rendering problems in DTP applications. Could you help me better understand the motivation here? Currently it lacks drawer validation, means it allows --factory-drawer-circle but isn't able to render those. |
Sorry, something went wrong.
|
I was initially annoyed sending svg files back and forth for art purposes taking up a bunch more space than it should. There's also an oddity with the box method of drawing where boxes touch other boxes, and it gets imported into a PDF or .ai file and then there are some fine lines in between each box. The svg-compressed mode doesn't have that problem since the paths don't have overlapping lines. |
Sorry, something went wrong.
| viewBox = "-{b} -{b} {d} {d}".format(d=dimension, b=self.border) | ||
| return super()._svg(viewBox=viewBox, **kwargs) | ||
|
|
||
| def _generate_subpaths(self): |
There was a problem hiding this comment.
It could be worth it to move this logic to a separate module altogether (moduledrawers/_svg_compressed.py?) so you could use less inner classes and enums?
Sorry, something went wrong.
Extensions for #342