media: i2c: Expand gain values for ov5693 - #168
Open
djrscally wants to merge 1 commit into
Open
Conversation
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
The ov5693 driver currently allows values for the V4L2_CID_ANALOGUE_GAIN control in the range 1-127. The input values are left-shifted 4 bits before being applied to the hardware. The 4 least significant bits are fractional bits, which means that in practice gain can only be applied in steps of 1.0. Update the allowed range to take any value that fits into the 11-bit register and stop masking off the fractional bits. Signed-off-by: Daniel Scally <dan.scally@ideasonboard.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ov5693 driver currently allows values for the
V4L2_CID_ANALOGUE_GAIN control in the range 1-127. The input values are left-shifted 4 bits before being applied to the hardware. The 4 least significant bits are fractional bits, which means that in practice gain can only be applied in steps of 1.0.
Update the allowed range to take any value that fits into the 11-bit register and stop masking off the fractional bits.
Note that libcamera treated the ov5693 as though this change were already applied, which meant that by default 16x gain was being applied. This change therefore reduces the noise of the user-facing camera quite a bit; see the attached images
