pkg/arch: Do not build in serial drivers - #1430
Closed
qzed wants to merge 2 commits into
Closed
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Since [1] we should not require the serial drivers to be built in any more. In essence, the PR causes the SAM driver to return EPROBE_DEFER when the serial device is not ready. Specifics on how to best handle this (i.e., which function should actually return EPROBE_DEFER) are still to be discussed, but for now this should provide a better workaround that hopefully fixes this problem as well. So let's test it. [1]: linux-surface/kernel#152
StollD
approved these changes
Apr 30, 2024
StollD
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Can you also add the new patch to the patchset? So that they are merged at the same time and we don't forget?
Sorry, something went wrong.
Changes: - Fix SAM driver probe failure when UART is not ready yet (@phreer). Links: - kernel: linux-surface/kernel@43ef589 - PR: linux-surface/kernel#152
Copy link
Copy Markdown
Member
Author
|
Good idea. Done. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
Superseded by https://lore.kernel.org/all/20240509141549.63704-1-hdegoede@redhat.com/ (integrated into our v6.9 patches) and commit 312dae7. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since linux-surface/kernel#152 we should not require the serial drivers to be built in any more. In essence, the PR causes the SAM driver to return EPROBE_DEFER when the serial device is not ready.
Specifics on how to best handle this (i.e., which function should actually return EPROBE_DEFER) are still to be determined, but for now linux-surface/kernel#152 should provide a better workaround that (at least in theory and based on limited testing) fixes this problem as well. So let's test if this holds up in practice.