Replace inxi with repolib - #271
Open
darkowlzz wants to merge 1 commit into
Open
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
Replaces inxi for gathering the repository signed-by key path with repolib. Executing inxi as a subprocess results in output in unexpected format under certain circumstances. The same can be gathered used repolib, in python, which is already used for loading the sources. `inxi -r` doesn't list the signed-by value for Deb822 sources. repolib supports extracting signed-by value for both legacy and Deb822 formatted sources. Adds basic unit tests that verifies the repository key path retrieval for various scenarios.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an attempt to address the bug reported in linuxmint/mintupdate#1036. As per my understanding of the problem, replacing inxi with native python code using repolib for the same operation seems like a better way to fix the problem, than using the inxi --tty flag that I suggested as a fix, in addition to adding support for Deb822 signed sources.
Replaces inxi for gathering the repository signed-by key path with repolib. Executing inxi as a subprocess results in output in unexpected format under certain circumstances, see linuxmint/mintupdate#1036 (comment) for details. The same can be gathered used repolib, in python, which is already used for loading the sources.
inxi -r doesn't list the signed-by value for Deb822 sources. repolib supports extracting signed-by value for both legacy and Deb822 formatted sources.
Adds basic unit tests that verifies the repository key path retrieval for various scenarios.
NOTE: I'm not so certain about the placement of the tests. Looking at the other repositories, it seemed it's better to place it at the root of the project as the usr/lib/linuxmint directory is copied to the root of the filesystem when installed.
Also, I could not find any existing reference for running the tests in CI in other repositories. If this patch is acceptable and the tests should be run in CI, I can add a github actions workflow for running the tests.