FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Automated install script and maintenance by Root-Core · Pull Request #523 · linuxserver/docker-nextcloud · GitHub

  1. linuxserver
  2. docker-nextcloud

Repository navigation

Automated install script and maintenance - #523

Closed
Root-Core wants to merge 7 commits into
linuxserver:masterfrom
Root-Core:install_script
ConversationCommits (7)ChecksFiles changed
Closed

Automated install script and maintenance#523
Root-Core wants to merge 7 commits into
linuxserver:masterfrom
Root-Core:install_script

Conversation

Root-Core commented Sep 13, 2025

Copy link
Copy Markdown

  • I have read the contributing guideline and understand that I have made the correct modifications

Description:

This implements an automated method to install nextcloud via env variables.

This implements some automated maintenance steps, which fixes annoying warnings in the admin panel and is more comfortable.

This implements a automated way to reset the admin's password via env variables.

This implements a loading mechanism for env variables from a file.

Disclaimer: I took some inspiration / code from the mariadb container.

Benefits of this PR and context:

Improved UX and automated deployment.

How Has This Been Tested?

This was tested with docker compose and mariadb. I tested multiple instances.

It doesn't affect other parts of the code, but the order of modifying files is altered to prevent issues.

Source / References:

https://github.com/linuxserver/docker-mariadb/blob/912096e6bcc4b8a0b0ec6b20f347a4e93dad7d1e/root/etc/s6-overlay/s6-rc.d/init-mariadb-initdb/run#L23

https://github.com/linuxserver/docker-mariadb/blob/912096e6bcc4b8a0b0ec6b20f347a4e93dad7d1e/readme-vars.yml#L43

github-actions Bot reviewed Sep 13, 2025
View reviewed changes

github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks for opening this pull request! Be sure to follow the pull request template!

Root-Core commented Sep 13, 2025

Copy link
Copy Markdown
Author

I found an issue with the current script: it does not create the CAN_INSTALL file.
I don't know why it works at all in the current container script. However, the script creates the file now.

LinuxServer-CI commented Sep 13, 2025

Copy link
Copy Markdown
Collaborator

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/nextcloud/31.0.9-pkg-1496f682-dev-8c2c2321c0245252d31a9c07d7db766309c6c783-pr-523/index.html
https://ci-tests.linuxserver.io/lspipepr/nextcloud/31.0.9-pkg-1496f682-dev-8c2c2321c0245252d31a9c07d7db766309c6c783-pr-523/shellcheck-result.xml

Tag Passed
amd64-31.0.9-pkg-1496f682-dev-8c2c2321c0245252d31a9c07d7db766309c6c783-pr-523 ✅
arm64v8-31.0.9-pkg-1496f682-dev-8c2c2321c0245252d31a9c07d7db766309c6c783-pr-523 ✅

LinuxServer-CI commented Oct 14, 2025

Copy link
Copy Markdown
Collaborator

This pull request has been automatically marked as stale because it has not had recent activity. This might be due to missing feedback from OP. It will be closed if no further activity occurs. Thank you for your contributions.

Root-Core commented Oct 14, 2025

Copy link
Copy Markdown
Author

Not stale, needs review.

LinuxServer-CI commented Oct 17, 2025

Copy link
Copy Markdown
Collaborator

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/nextcloud/32.0.0-pkg-03cff81d-dev-660c6b13afa7f95237aec63da55444ed79b18969-pr-523/index.html
https://ci-tests.linuxserver.io/lspipepr/nextcloud/32.0.0-pkg-03cff81d-dev-660c6b13afa7f95237aec63da55444ed79b18969-pr-523/shellcheck-result.xml

Tag Passed
amd64-32.0.0-pkg-03cff81d-dev-660c6b13afa7f95237aec63da55444ed79b18969-pr-523 ✅
arm64v8-32.0.0-pkg-03cff81d-dev-660c6b13afa7f95237aec63da55444ed79b18969-pr-523 ✅

LinuxServer-CI commented Nov 13, 2025

Copy link
Copy Markdown
Collaborator

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/nextcloud/32.0.1-pkg-ad39a256-dev-913967807ff6af259081dec47e8f8d1b646a8c79-pr-523/index.html
https://ci-tests.linuxserver.io/lspipepr/nextcloud/32.0.1-pkg-ad39a256-dev-913967807ff6af259081dec47e8f8d1b646a8c79-pr-523/shellcheck-result.xml

Tag Passed
amd64-32.0.1-pkg-ad39a256-dev-913967807ff6af259081dec47e8f8d1b646a8c79-pr-523 ✅
arm64v8-32.0.1-pkg-ad39a256-dev-913967807ff6af259081dec47e8f8d1b646a8c79-pr-523 ✅

LinuxServer-CI commented Dec 10, 2025

Copy link
Copy Markdown
Collaborator

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/nextcloud/32.0.2-pkg-a3e3559c-dev-088fee6d96d294ce3674199dfd60d2144c5c2f33-pr-523/index.html
https://ci-tests.linuxserver.io/lspipepr/nextcloud/32.0.2-pkg-a3e3559c-dev-088fee6d96d294ce3674199dfd60d2144c5c2f33-pr-523/shellcheck-result.xml

Tag Passed
amd64-32.0.2-pkg-a3e3559c-dev-088fee6d96d294ce3674199dfd60d2144c5c2f33-pr-523 ✅
arm64v8-32.0.2-pkg-a3e3559c-dev-088fee6d96d294ce3674199dfd60d2144c5c2f33-pr-523 ✅

LinuxServer-CI commented Jan 6, 2026

Copy link
Copy Markdown
Collaborator

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/nextcloud/32.0.3-pkg-c71addf9-dev-f73240b796be80b4819cb9deb95ef5f56c5e68c3-pr-523/index.html
https://ci-tests.linuxserver.io/lspipepr/nextcloud/32.0.3-pkg-c71addf9-dev-f73240b796be80b4819cb9deb95ef5f56c5e68c3-pr-523/shellcheck-result.xml

Tag Passed
amd64-32.0.3-pkg-c71addf9-dev-f73240b796be80b4819cb9deb95ef5f56c5e68c3-pr-523 ✅
arm64v8-32.0.3-pkg-c71addf9-dev-f73240b796be80b4819cb9deb95ef5f56c5e68c3-pr-523 ✅

LinuxServer-CI commented Feb 2, 2026

Copy link
Copy Markdown
Collaborator

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/nextcloud/32.0.5-pkg-b1f8c269-dev-16f35223561640f9034ef79e55e1ad7165b325cd-pr-523/index.html
https://ci-tests.linuxserver.io/lspipepr/nextcloud/32.0.5-pkg-b1f8c269-dev-16f35223561640f9034ef79e55e1ad7165b325cd-pr-523/shellcheck-result.xml

Tag Passed
amd64-32.0.5-pkg-b1f8c269-dev-16f35223561640f9034ef79e55e1ad7165b325cd-pr-523 ✅
arm64v8-32.0.5-pkg-b1f8c269-dev-16f35223561640f9034ef79e55e1ad7165b325cd-pr-523 ✅

LinuxServer-CI commented Mar 1, 2026

Copy link
Copy Markdown
Collaborator

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/nextcloud/33.0.0-pkg-b7f49bbf-dev-4ffdbc913953925f9171b5279c7e604b5b085143-pr-523/index.html
https://ci-tests.linuxserver.io/lspipepr/nextcloud/33.0.0-pkg-b7f49bbf-dev-4ffdbc913953925f9171b5279c7e604b5b085143-pr-523/shellcheck-result.xml

Tag Passed
amd64-33.0.0-pkg-b7f49bbf-dev-4ffdbc913953925f9171b5279c7e604b5b085143-pr-523 ✅
arm64v8-33.0.0-pkg-b7f49bbf-dev-4ffdbc913953925f9171b5279c7e604b5b085143-pr-523 ✅

Root-Core commented Mar 1, 2026

Copy link
Copy Markdown
Author

@linuxserver Is there any chance to get this merged?

LinuxServer-CI commented Mar 28, 2026

Copy link
Copy Markdown
Collaborator

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/nextcloud/33.0.1-pkg-dbd02057-dev-2e30dacabebe751089dc29e406755544a147e2c2-pr-523/index.html
https://ci-tests.linuxserver.io/lspipepr/nextcloud/33.0.1-pkg-dbd02057-dev-2e30dacabebe751089dc29e406755544a147e2c2-pr-523/shellcheck-result.xml

Tag Passed
amd64-33.0.1-pkg-dbd02057-dev-2e30dacabebe751089dc29e406755544a147e2c2-pr-523 ✅
arm64v8-33.0.1-pkg-dbd02057-dev-2e30dacabebe751089dc29e406755544a147e2c2-pr-523 ✅

LinuxServer-CI commented Apr 24, 2026

Copy link
Copy Markdown
Collaborator

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/nextcloud/33.0.2-pkg-9b48ead1-dev-8a3ebff181fdfafea02ba0de8ada87677995fcc9-pr-523/index.html
https://ci-tests.linuxserver.io/lspipepr/nextcloud/33.0.2-pkg-9b48ead1-dev-8a3ebff181fdfafea02ba0de8ada87677995fcc9-pr-523/shellcheck-result.xml

Tag Passed
amd64-33.0.2-pkg-9b48ead1-dev-8a3ebff181fdfafea02ba0de8ada87677995fcc9-pr-523 ✅
arm64v8-33.0.2-pkg-9b48ead1-dev-8a3ebff181fdfafea02ba0de8ada87677995fcc9-pr-523 ✅

LinuxServer-CI commented May 25, 2026

Copy link
Copy Markdown
Collaborator

This pull request has been automatically marked as stale because it has not had recent activity. This might be due to missing feedback from OP. It will be closed if no further activity occurs. Thank you for your contributions.

Root-Core commented May 25, 2026

Copy link
Copy Markdown
Author

This still needs review and is not stale.

aptalca commented May 26, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Thanks for the PR, but to be honest, I'm not in favor of it. It adds too much complexity for little gain.

You mentioned you got inspiration from the mariadb container but to be clear, the reasons we added those auto set up operations there are 1) mariadb doesn't have a setup wizard and 2) mariadb does support auto setup via script and/or conf file. Whereas Nextcloud already has a setup wizard that is pretty nice and intuitive.

This PR would significantly increase the maintenance and support burden for us for too little gain and thus has a high cost to benefit ratio.

PS. Even the mariadb container's setup vars are effective first time only. Changing the admin password later on does nothing, and that was intentional.

Root-Core commented May 28, 2026

Copy link
Copy Markdown
Author

Thank you for reviewing the PR. 👍🏻

The changes only call some occ commands in order to reduce the maintenance burden on users / administrators.
At the moment you need to call the migration steps manually after upgrades (not possible via the web interface).

PS. Even the mariadb container's setup vars are effective first time only. Changing the admin password later on does nothing, and that was intentional.

Besides the password this is also the case in this PR. It just offers a convenient, declarative setup.

I understand if that's not your approach, but I don't see where it spawns additional significant maintenance burden.
It adds four new calls (2x necessary maintenance, setup, password) and some environment variables.

The rest is just moving around some things for a better program flow and documentation.

  1. mariadb does support auto setup via script

So does NextCloud via occ. It's just a different interface for the same functionality.

aptalca commented May 29, 2026

Copy link
Copy Markdown
Member

https://www.linuxserver.io/blog/why-cant-you-just-implement-thing-i-want

I understand if that's not your approach, but I don't see where it spawns additional significant maintenance burden.

It's maintenance and support burden. Each new env var added (even if optional), means a bunch of users will try to set them, and incorrectly, needing support. Many of our users don't read. K.I.S.S. is a valuable principle for us.

Root-Core mentioned this pull request Jun 1, 2026
Open
1 task done

Root-Core commented Jun 1, 2026

Copy link
Copy Markdown
Author

@aptalca I see, this won't be merged then.

So I just opened #540 with the maintenance parts only - I hope this is less problematic, as it does not add env vars.

Root-Core closed this Jun 1, 2026
LinuxServer-CI moved this from PRs to Done in Issue & PR Tracker Jun 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

github-actions[bot] github-actions[bot] left review comments

Assignees

No one assigned

Labels

None yet

Projects

Issue & PR Tracker
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL