Add :native_tls option to Pythonx.uv_init/2 - #41
Conversation
Sorry, something went wrong.
| - `["--native-tls"]` - use the system's native TLS implementation instead | ||
| of vendored rustls. This is useful in corporate environments where the | ||
| system certificate store must be used. | ||
| - `["--no-cache"]` - disable the cache, forcing a fresh download of all | ||
| packages. | ||
| - `["--reinstall"]` - force reinstallation of all packages, even if they | ||
| are already present. | ||
| - `["--quiet"]` - suppress output from the uv command. |
There was a problem hiding this comment.
I would prefer to just have an Elixir option :native_tls. This way we have more control over where how and where we pass specific CLI options. Also, we already have :force, so no need to use --no-cache or --reinstall. @josevalim wdyt?
Sorry, something went wrong.
There was a problem hiding this comment.
I think I agree, as we cannot guarantee all of the options will work with Pythonx...
Sorry, something went wrong.
There was a problem hiding this comment.
Are there other options you would want as part of this PR or just limit it to :native_tls?
Sorry, something went wrong.
There was a problem hiding this comment.
Let's do native tls for now. We can add more options if someone has a need for it :)
Sorry, something went wrong.
GenericJam
left a comment
There was a problem hiding this comment.
Are we happy with these changes now?
Sorry, something went wrong.
Added support and a bit of validation and tests.
Let me know if you want something different.