This repository was archived by the owner on Aug 31, 2021. It is now read-only.
[[ Bug ]] Fix failing LCB varargs test on Linux - #7024
Merged
runrevmark merged 1 commit intoMay 10, 2019
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
This patch fixes the LCB varargs tests on Linux. The test was failing due to the assumption that the %p printf format would render a nullptr as 0x0 as it does on macOS - this was an incorrect assumption. To resolve this, the varargs tests have been restructured, with the nullptr test being separated out. Rather than check for a specific output string, it just checks it begins with the known string (the issue was a crash, so the only thing which needs to be checked is that the crash doesn't happen!).
Copy link
Copy Markdown
Contributor
|
💙 review by @montegoulding ok 9727a9b |
Sorry, something went wrong.
livecode-vulcan
added a commit
that referenced
this pull request
May 10, 2019
[[ Bug ]] Fix failing LCB varargs test on Linux This patch fixes the LCB varargs tests on Linux. The test was failing due to the assumption that the %p printf format would render a nullptr as 0x0 as it does on macOS - this was an incorrect assumption. To resolve this, the varargs tests have been restructured, with the nullptr test being separated out. Rather than check for a specific output string, it just checks it begins with the known string (the issue was a crash, so the only thing which needs to be checked is that the crash doesn't happen!).
Copy link
Copy Markdown
Contributor
|
😎 test success 9727a9b
|
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch fixes the LCB varargs tests on Linux. The test was failing
due to the assumption that the %p printf format would render a nullptr
as 0x0 as it does on macOS - this was an incorrect assumption.
To resolve this, the varargs tests have been restructured, with the
nullptr test being separated out. Rather than check for a specific
output string, it just checks it begins with the known string (the
issue was a crash, so the only thing which needs to be checked is
that the crash doesn't happen!).