This repository was archived by the owner on Aug 31, 2021. It is now read-only.
[[ Build ]] Make use of thirdparty prebuilts optional - #7297
Open
livecodeian wants to merge 2 commits into
Open
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
added 2 commits
March 18, 2020 18:35
This patch modifies any dependencies to thirdparty libraries within gyp files to refer to the gyp of that library within the thirdparty submodule rather than directly to the prebuilt/thirdparty.gyp file. Use of thirdparty library prebuilt binaries can now be controlled by setting the 'use_prebuilt_thirdparty' gyp variable, which has a default value of '1' (use prebuilt thirdparty libraries).
This patch modifies the config.py script to check if the BUILD_THIRDPARTY environment variable has been defined, and if so pass the variable 'use_prebuilt_thirdparty' to gyp with a value of 0, disabling the use of prebuilt thirdparty libraries and causing those libraries to be compiled from source.
Copy link
Copy Markdown
Contributor
|
💙 review by @montegoulding ok 4f62f2a |
Sorry, something went wrong.
livecode-vulcan
added a commit
that referenced
this pull request
Mar 27, 2020
…hirdparty-prebuilts [[ Build ]] Make use of thirdparty prebuilts optional This PR allows the use of prebuilt thirdparty libraries to be determined by the 'BUILD_THIRDPARTY' environment variable. If this variable is set when configuring the build project files (i.e. with `make config-<platform>`) then rather than use the prebuilt thirdparty libraries these libraries will be compiled from source. *Note* - depends on livecode/livecode-thirdparty#142
Copy link
Copy Markdown
Contributor
|
😞 test failure 4f62f2a
|
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Would like to give this PR a bump. It's currently blocking my native arm compilation and would also increase testability for newer versions of thirdparty prebuilt libraries. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR allows the use of prebuilt thirdparty libraries to be determined by the 'BUILD_THIRDPARTY' environment variable. If this variable is set when configuring the build project files (i.e. with make config-<platform>) then rather than use the prebuilt thirdparty libraries these libraries will be compiled from source.
Note - depends on livecode/livecode-thirdparty#142