FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Make 'working screenrect' to return the safe area on iOS by livecodepanos · Pull Request #7455 · livecode/livecode · GitHub

This repository was archived by the owner on Aug 31, 2021. It is now read-only.
/ livecode Public archive

Make 'working screenrect' to return the safe area on iOS - #7455

Open
livecodepanos wants to merge 1 commit into
livecode:develop-9.6from
livecodepanos:ios_working_screenrect_2
Open

Make 'working screenrect' to return the safe area on iOS#7455
livecodepanos wants to merge 1 commit into
livecode:develop-9.6from
livecodepanos:ios_working_screenrect_2

Conversation

Copy link
Copy Markdown
Contributor

No description provided.

livecodepanos changed the title Ios working screenrect 2 [[ WIP ]] Tweak working screenrect to return the safe area on iOS Oct 19, 2020

Copy link
Copy Markdown
Contributor Author

WIP because this results in black screen, even though the correct safe area is reported:

Copy link
Copy Markdown
Contributor Author

Note that the safe area is actually the screen rect excluding the area of the top notch and the bottom area of the soft "home" button:

Copy link
Copy Markdown
Contributor Author

I believe the "black screen" problem is caused because the value of the member variable workarea (of struct MCDisplay) is used in other places in the engine as well, so these places do not like the workarea having the value of the safe area. Or because bool MCScreenDC::platform_getdisplays(bool p_effective, MCDisplay *&r_displays, uint32_t &r_count) is used in several other places apart from MCInterfaceGetScreenRect, and again, these places probably do not like the new value of r_displays[0] -> workarea which is now the safe area.

livecodepanos force-pushed the ios_working_screenrect_2 branch from 144aba6 to 45786f4 Compare October 20, 2020 11:41
livecodepanos force-pushed the ios_working_screenrect_2 branch from 45786f4 to fe60c9a Compare October 20, 2020 12:32

Copy link
Copy Markdown
Contributor Author

I have pushed some changes that fix the black screen issue. The working screenrect now reports the safe area, at any point it is called (i.e. either on preopenstack or later after the opencard is sent.

livecodepanos removed the WIP label Oct 20, 2020
livecodepanos changed the title [[ WIP ]] Tweak working screenrect to return the safe area on iOS Make 'working screenrect' to return the safe area on iOS Oct 20, 2020
livecodepanos added this to the 9.6.2-rc-1 milestone Oct 27, 2020
runrevmark added the WIP label Oct 28, 2020
livecodepanos removed this from the 9.6.2-rc-1 milestone Nov 24, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants


Back | FazBrowse Home | New Git URL