This repository was archived by the owner on Aug 31, 2021. It is now read-only.
[[ Bug 22994 ]] Fix crash when setting the startTime of a video on iOS - #7492
Open
livecodepanos wants to merge 1 commit into
Open
[[ Bug 22994 ]] Fix crash when setting the startTime of a video on iOS#7492livecodepanos wants to merge 1 commit into
livecodepanos wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
This patch fixes a crash when setting the startTime of a video on iOS
livecodeian
reviewed
May 24, 2021
Comment thread
engine/src/mbliphoneplayer.mm
|
|
||
| if (m_player != nil) | ||
| m_player.currentItem.reversePlaybackEndTime = m_start_time; | ||
| SetCurrentTime(ctxt, p_time); |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
@livecodepanos SetCurrentTime just seeks to that position. the startTime should specify the position that the video begins playback from, including when looping
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Reviewers
1 more reviewer3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch fixes a crash when setting the startTime of a video on iOS