FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

[[ Bug 23234 ]] Fix iOS standalone build error when running from source by livecodepanos · Pull Request #7580 · livecode/livecode · GitHub

This repository was archived by the owner on Aug 31, 2021. It is now read-only.
/ livecode Public archive

[[ Bug 23234 ]] Fix iOS standalone build error when running from source - #7580

Open
livecodepanos wants to merge 1 commit into
livecode:develop-9.6from
livecodepanos:fix_too_many_levels_of_symbolic_links
ConversationCommits (1)ChecksFiles changed
Open

[[ Bug 23234 ]] Fix iOS standalone build error when running from source#7580
livecodepanos wants to merge 1 commit into
livecode:develop-9.6from
livecodepanos:fix_too_many_levels_of_symbolic_links

Conversation

livecodepanos commented Jun 10, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor

This patch fixes the error:

Failed to open macho file at 
/../Xcodes/Xcode_12_5_0.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/clang++ 
for reading: Too many levels of symbolic links

It seems there is a chance g++ is not symlinked correctly, so use the full path to clang++ instead.

Closes https://quality.livecode.com/show_bug.cgi?id=23234

[[ Bug 23234 ]] Fix iOS standalone build error when running from source
883a684 
This patch fixes the error:

Failed to open macho file at
/../Xcodes/Xcode_12_5_0.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/clang++
for reading: Too many levels of symbolic links

It seems there is a chance g++ is not symlinked correctly, so use the full path to clang++ instead.
livecodepanos added this to the 9.6.3-rc-1 milestone Jun 10, 2021
livecodepanos mentioned this pull request Jun 10, 2021
Merged
runrevmark suggested changes Jun 10, 2021
View reviewed changes

runrevmark left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Why is this only an issue when running from source?

In any case, please file a BZ issue so it has an issue number and update commit message / PR appropriately.

livecodepanos force-pushed the fix_too_many_levels_of_symbolic_links branch from 2e71675 to 9fdaa32 Compare June 10, 2021 08:11
livecodepanos changed the title [[ S/B ]] Fix iOS build standalone error when running from source [[ Bug 23234 ]] Fix iOS standalone build error when running from source Jun 10, 2021
livecodepanos force-pushed the fix_too_many_levels_of_symbolic_links branch 2 times, most recently from e3fe7ec to 883a684 Compare June 10, 2021 08:14

livecodepanos commented Jun 10, 2021

Copy link
Copy Markdown
Contributor Author

@runrevmark Done :)

Does it need a release note, or is it considered "internal"?

livecodepanos requested a review from runrevmark June 10, 2021 08:16

runrevmark commented Jun 10, 2021

Copy link
Copy Markdown
Contributor

I think its esoteric enough that it doesn't need a release note - although how is g++ not symlinked correctly? Is it something about your setup? Something one of our internals setup scripts does?

livecodepanos commented Jun 10, 2021

Copy link
Copy Markdown
Contributor Author

I do not think it is my setup, since @montegoulding experienced the same issue a couple of months ago with Xcode 12.4. It might be because of a change in recent Xcodes, since I see this error with Xcode 12.5, but not with Xcode 11.3 in a different Mac.

My understanding is that somehow g++ symlinks to Xcode_12_5_0.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/clang++, but the latter is a symlink as well (to Xcode_12_5_0.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/clang), hence the too many symbolic links error.

runrevmark commented Jun 10, 2021

Copy link
Copy Markdown
Contributor

Okay so it sounds like it isn't necessarily a build from source issue then - isn't the modified code in code that runs in a built IDE too?

livecodepanos commented Jun 10, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

The modified code is in the S/B, which does run in a built IDE too. It does not seem to happen with Xcode 12.1, otherwise people would have noticed. We have not released a build that supports Xcode 12.4 or Xcode 12.5 so far, so I am not entirely sure if this is a build from source issue or a general Xcode12.4+ issue. I think I will be able to tell if this is the case when #7579 is merged and we kick off a new build. So I am marking this PR as WIP until then

runrevmark commented Jun 10, 2021

Copy link
Copy Markdown
Contributor

Ah! Okay well if it is an xcode 12.4/12.5 issue then it doesn't need a release note as it won't have affected anyone :)

runrevmark commented Jun 30, 2021

Copy link
Copy Markdown
Contributor

@livecodepanos Is this definitely an issue we need to resolve for the new Xcode update?

livecodepanos commented Jun 30, 2021

Copy link
Copy Markdown
Contributor Author

@runrevmark I have checked with a built version of 9.6.3 rc1 from staging, with Xcode 12.5, and this issue is not present. So it seems it happens only when building from source.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

runrevmark Awaiting requested review from runrevmark

Assignees

No one assigned

Labels

blocker bug WIP

Projects

None yet

Milestone

9.6.3-rc-1

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL