This repository was archived by the owner on Aug 31, 2021. It is now read-only.
[[ Bug 23038 ]] Fix creation of color profiles on macOS - #7596
Merged
livecodepanos merged 1 commit intoJul 20, 2021
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
This patch fixes an issue with the creation of color profiles from embedded ICC information. Previously the NoCopy CFDataRef constructor was being used to wrap the raw bytes to be passed to the relevant CGColorSpaceRef constructor. However, the data wrapped in this way could be released at any time, and in versions of macOS since Mojave it appears that the OS defers copying the data thus causing strange effects when the color profile is eventually applied. The problem has been fixed by using the normal CFDataRef constructor which copies the provided bytes.
Copy link
Copy Markdown
Contributor
|
💙 review by @livecodeian ok d6a9244 |
Sorry, something went wrong.
livecode-vulcan
added a commit
that referenced
this pull request
Jul 20, 2021
[[ Bug 23038 ]] Fix creation of color profiles on macOS This patch fixes an issue with the creation of color profiles from embedded ICC information. Previously the NoCopy CFDataRef constructor was being used to wrap the raw bytes to be passed to the relevant CGColorSpaceRef constructor. However, the data wrapped in this way could be released at any time, and in versions of macOS since Mojave it appears that the OS defers copying the data thus causing strange effects when the color profile is eventually applied. The problem has been fixed by using the normal CFDataRef constructor which copies the provided bytes. Closes https://quality.livecode.com/show_bug.cgi?id=23038
Copy link
Copy Markdown
Contributor
|
😎 test success d6a9244
|
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch fixes an issue with the creation of color profiles from
embedded ICC information. Previously the NoCopy CFDataRef constructor
was being used to wrap the raw bytes to be passed to the relevant
CGColorSpaceRef constructor. However, the data wrapped in this way
could be released at any time, and in versions of macOS since
Mojave it appears that the OS defers copying the data thus causing
strange effects when the color profile is eventually applied. The
problem has been fixed by using the normal CFDataRef constructor
which copies the provided bytes.
Closes https://quality.livecode.com/show_bug.cgi?id=23038