fix schedule speech on windows when monotonic_ns resolution is rough - #2770
Merged
longcw merged 2 commits intoJul 1, 2025
Merged
fix schedule speech on windows when monotonic_ns resolution is rough#2770longcw merged 2 commits into
longcw merged 2 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
davidzhao
approved these changes
Jul 1, 2025
davidzhao
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
nice fix!
Sorry, something went wrong.
Comment thread
livekit-agents/livekit/agents/voice/agent_activity.py
| # negate the priority to make it a max heap | ||
| heapq.heappush(self._speech_q, (-priority, time.perf_counter_ns(), speech)) | ||
| break | ||
| except TypeError: |
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
maybe comment here on why TypeError is thrown? (it's clear when reading the bug, but that context is lost when reading the code alone)
Sorry, something went wrong.
theomonnom
approved these changes
Jul 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before python 3.13, on Windows, time.monotonic() uses gGetTickCount64() clock which has a resolution of 15.6 ms.
python/cpython#116781
Replaced it with time.perf_counter_ns for python < 3.13 on Windows, fix #2764