PlatformAudio - #140
Merged
stephen-derosa merged 10 commits intoJun 10, 2026
Merged
Conversation
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
stephen-derosa
requested review from
alan-george-lk and
xianshijing-lk
as code owners
May 27, 2026 18:01
stephen-derosa
marked this pull request as draft
May 27, 2026 18:01
Copy link
Copy Markdown
There was a problem hiding this comment.
Pull request overview
This PR introduces a new PlatformAudio API to expose WebRTC platform audio (ADM-backed capture/playout with voice processing) through the C++ SDK’s FFI layer, and wires it into LocalAudioTrack creation, with docs and unit coverage.
Changes:
- Add public PlatformAudio / PlatformAudioSource API and FFI-backed implementation.
- Add LocalAudioTrack::createLocalAudioTrack overload for PlatformAudioSource.
- Add README documentation and new unit tests for platform audio behavior.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 4 comments.
Show a summary per file| File | Description |
|---|---|
| src/tests/unit/test_platform_audio.cpp | Adds unit tests covering default options, device info fields, and creating a track from a platform source. |
| src/platform_audio.cpp | Implements PlatformAudio and PlatformAudioSource over synchronous FFI requests. |
| src/local_audio_track.cpp | Adds shared helper for track creation and an overload accepting PlatformAudioSource. |
| README.md | Documents recommended usage of PlatformAudio vs AudioSource, with a C++ example. |
| include/livekit/platform_audio.h | Adds the public PlatformAudio API surface, options, device info, and error type with Doxygen docs. |
| include/livekit/local_audio_track.h | Adds forward declaration + new overload and expands/updates Doxygen docs. |
| include/livekit/livekit.h | Exposes platform_audio.h from the umbrella header. |
| CMakeLists.txt | Adds src/platform_audio.cpp to the shared library build. |
| AGENTS.md | Updates threading-model docs and adds PlatformAudio to the thread-safety table. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sorry, something went wrong.
Comment thread
AGENTS.md
Outdated
Comment thread
src/local_audio_track.cpp
Comment thread
src/platform_audio.cpp
Outdated
Comment thread
src/platform_audio.cpp
Outdated
stephen-derosa
force-pushed
the
sderosa/BOT-377-platform-audio
branch
2 times, most recently
from
5a12680 to
9d3618c
Compare
June 2, 2026 02:37
stephen-derosa
commented
Jun 2, 2026
Comment thread
include/livekit/platform_audio.h
stephen-derosa
marked this pull request as ready for review
June 2, 2026 03:36
stephen-derosa
force-pushed
the
sderosa/BOT-377-platform-audio
branch
from
ef9f1fe to
a7d1829
Compare
June 2, 2026 04:05
xianshijing-lk
left a comment
Copy link
Copy Markdown
Collaborator
There was a problem hiding this comment.
one question, it looks pretty good from a quick look.
Sorry, something went wrong.
Comment thread
include/livekit/platform_audio.h
Comment thread
include/livekit/local_audio_track.h
Outdated
Comment thread
include/livekit/local_audio_track.h
Outdated
Comment thread
include/livekit/local_audio_track.h
Comment thread
include/livekit/platform_audio.h
Outdated
Comment thread
include/livekit/platform_audio.h
Outdated
Comment thread
src/tests/unit/test_platform_audio.cpp
Comment thread
src/local_audio_track.cpp
Outdated
Comment thread
src/platform_audio.cpp
Outdated
Comment thread
src/platform_audio.cpp
Comment thread
src/platform_audio.cpp
Outdated
stephen-derosa
force-pushed
the
sderosa/BOT-377-platform-audio
branch
2 times, most recently
from
f4b7466 to
32bfa39
Compare
June 3, 2026 18:26
alan-george-lk
approved these changes
Jun 4, 2026
Comment thread
include/livekit/local_audio_track.h
Outdated
stephen-derosa
force-pushed
the
sderosa/BOT-377-platform-audio
branch
from
32bfa39 to
97a4b6d
Compare
June 4, 2026 17:55
stephen-derosa
force-pushed
the
sderosa/BOT-377-platform-audio
branch
from
97a4b6d to
3ef5197
Compare
June 8, 2026 19:51
xianshijing-lk
approved these changes
Jun 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
Assignees
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Implement PlatformAudio over ffi
Examples
https://github.com/livekit-examples/cpp-example-collection/compare/sderosa/BOT-377-platform-audio?expand=1