Use cpp-tools - #162
Merged
alan-george-lk merged 27 commits intoJul 20, 2026
Merged
Conversation
Delegate C++ checks to the reusable cpp-tools workflow so clang-format, clang-tidy, and future documentation checks can be configured from one source of truth. Co-authored-by: Cursor <cursoragent@cursor.com>
Remove the local C++ checks wrapper so ci.yml delegates straight to the shared cpp-tools workflow configuration. Co-authored-by: Cursor <cursoragent@cursor.com>
xianshijing-lk
approved these changes
Jun 11, 2026
…otstrap-cpp-tools
…otstrap-cpp-tools
…otstrap-cpp-tools
stephen-derosa
approved these changes
Jul 17, 2026
stephen-derosa
left a comment
Copy link
Copy Markdown
Collaborator
There was a problem hiding this comment.
lgtm!
Sorry, something went wrong.
Comment thread
README.md
Outdated
| `clang-tidy`, `clang-format`, `valgrind`, and Doxygen are all wired up via | ||
| scripts under `scripts/`. Set up the pre-commit auto-formatter | ||
| with: | ||
| `clang-tidy` and `clang-format` are provided by the `cpp-tools` submodule. |
Copy link
Copy Markdown
Collaborator
There was a problem hiding this comment.
the "valgrind and Doxygen remain documented with ...." feels kind of out of place to be referencing history
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Author
There was a problem hiding this comment.
Good call -- fixed to be less historical and flow better
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.