refactor: remove direct flutter_webrtc dependency - #52
Merged
hiroshihorie merged 5 commits intoAug 3, 2026
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Screen share now goes through the livekit_client helpers, ScreenSelectDialog.show for the desktop source picker and Hardware.requestCapturePermission for Android. This removes the exact flutter_webrtc pin that had to move in lockstep with livekit_client and caused resolution conflicts when the two drifted (#49). The livekit_client git override is temporary until the helpers ship in a release, then the constraint gets bumped and the override removed. The flutter_webrtc check in check_version.dart is obsolete now that the version is resolved only through livekit_client.
AGP 8.9.1 and Gradle 8.14 are required by androidx.core 1.18 which comes with the newer dependency tree. Remaining changes are Flutter tool migrations and regenerated plugin registrations.
The screenshare helpers merged, the feature branch will go away. Test against the actual 2.10.0 release candidate until it is on pub.dev.
Xcode puts Swift package checkouts under build when building the example for iOS or macOS, livekit_client ships Package.swift since 2.10.0, and the analyzer walks into the vendored repos.
hiroshihorie
added a commit
to livekit/client-sdk-flutter
that referenced
this pull request
Aug 3, 2026
## What Folds the pending changesets into the 2.10.0 release. Version propagated by `scripts/create_version.dart`, all version checks pass, `.changes/` emptied. ## Changelog * Added: Swift Package Manager support for iOS and macOS. CocoaPods remains fully supported. (#1142) * Added: `ScreenSelectDialog.show` and `Hardware.requestCapturePermission` so apps can start screen share without importing flutter_webrtc (#1147) * Fixed: Compile errors on Dart 3.13 where nullable publish options are no longer promoted across await (#1146) * Fixed: Omit data stream totalLength when size is unknown (#1141) * Fixed: Harden the example RPC tester (#1085) Minor bump driven by the SPM and screen share additions. ## Why now Dart 3.13 (Flutter 3.47 beta, soon stable) fails to compile every published livekit_client, so #1146 needs to ship before 3.47 lands. The screen share helpers unblock livekit/components-flutter#52, which removes the flutter_webrtc pin conflict that downgrades users to livekit_client 2.6.1 (livekit/components-flutter#49). ## After merge Tag `v2.10.0` to publish. First run of the reworked publish workflow from #1140 (tag guard, pin-warning-only validation gate, forced publish). Downstream: components-flutter #52 switches to `livekit_client: ^2.10.0`, then a components release and an agent-starter-flutter bump.
The typed screen share helpers shipped, drop the temporary git overrides and bump the constraint. Also exclude the example build directory from analysis for the same SPM checkout reason as the root package.
hiroshihorie
marked this pull request as ready for review
August 3, 2026 17:37
Merged
hiroshihorie
added a commit
that referenced
this pull request
Aug 3, 2026
## What Folds the pending changesets into the 1.3.1 release. Version propagated by `scripts/create_version.dart`, all version checks pass, `.changes/` emptied. ## Changelog * Changed: Remove the direct flutter_webrtc dependency, screen share now uses livekit_client helpers (#52) * Docs: Add AudioVisualizerWidget documentation (#48) ## Why now Published 1.3.0 pins flutter_webrtc 1.2.1 exactly, which forces resolution down to livekit_client 2.6.1 for every consumer including the agent starter (#49). This release depends on livekit_client ^2.10.0 with no flutter_webrtc pin, so resolution always follows whatever livekit_client pins. ## After merge Tag `v1.3.1` to publish. With the pin gone there is no expected validation warning, so the stock publish workflow should pass as is. Downstream: agent-starter-flutter bumps to `livekit_components: ^1.3.1` and `livekit_client: ^2.10.0`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Removes the direct flutter_webrtc dependency. The one place that used it, the screen share flow in MediaDeviceContext, now goes through livekit_client helpers shipped in 2.10.0 (livekit/client-sdk-flutter#1147):
Also removes the flutter_webrtc lockstep assertion from scripts/check_version.dart, which is obsolete once the version is resolved only through livekit_client, bumps the example Android toolchain (AGP 8.9.1, Gradle 8.14) as required by androidx.core 1.18 from the newer dependency tree, and excludes build directories from analysis since Xcode vendors Swift package checkouts there now that livekit_client ships Package.swift.
Why
Both this package and livekit_client pinned flutter_webrtc to an exact version, and the two must move in lockstep. The published 1.3.0 pins 1.2.1 while livekit_client pins newer versions, so resolution silently downgrades users to livekit_client 2.6.1 (#49). With no direct dependency, the flutter_webrtc version is always exactly what livekit_client pins and this class of conflict cannot recur.
Merge gates
Verification
Fixes #49