token create: don't show default localhost URL in output - #841
Open
c-tonneslan wants to merge 1 commit into
Open
token create: don't show default localhost URL in output#841c-tonneslan wants to merge 1 commit into
c-tonneslan wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
When no project URL is configured, the --url flag falls back to its default of http://localhost:7880, and that default was getting printed as "Project URL" in the token output. That's confusing since the user didn't configure anything. Now we skip the URL line if it wasn't explicitly set.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #800.
The --url flag defaults to http://localhost:7880 for dev convenience, but that default was getting printed as "Project URL" in lk token create output even when the user never configured a URL. Confusing, since it implies the token is tied to that server when really it isn't.
Now we skip the "Project URL" line if the URL wasn't explicitly set. If the user passes --url or sets LIVEKIT_URL, it still shows up as before.
Before:
After (when no URL configured):