Remove trailing slash when building url - #858
Open
s3bw wants to merge 1 commit into
Open
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
Copy link
Copy Markdown
|
|
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
I think we should use a proper URL builder here, instead of string manipulations. the current code seems fragile and a bit difficult to reason with. i.e. u, err := url.Parse(baseUrl)
if err != nil {
log.Fatal(err)
}
q := u.Query()
q.Set("url", ...)
u.RawQuery = q.Encode()
fmt.Println(u) |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is host dependent, but providing example.com/?url... can be treated as a different path to example.com?url....
Instead we rely on what ever the user provides as base_url and append the query params to that base url.