Hello,
i added support for unicode filenames for Form.LoadProps() methods.
Initially I thought it would be short and simple, but correct work with unicode and filesystem has its quirks.
Also be conforming to python PEPs added some work.
Since there are a lot of possible exceptions and errors, i also extended support for unicode exceptions somewhat. The additional features are:
LoadProps now support unicode string as filepath
LoadProps now support bytes as filepath
LoadProps now support os.PathLike objects as filepath
Generic handler for Delphi exceptions -> Python exceptions has been added (as a mirror to RaiseError; which handles python exception -> delphi exception)
There was no test for python vcl/fmx libraries, so i added one file per library - though i added only tests for new unicode functionality. I know its not completely conceptual, but i didnt want to add to this PR too much new stuff and since there wasnt nothing yet... The test is runnable either standalone without any additional dependencies, or via pytest (for more nice and detailed output)
Note: I want to apologize beforehand - im not delphi pro, last time i worked more with delphi was 25yrs ago, so i want to apologize for the stupid stuff i may have made. However sometime ago i accidentaly found delphifmx and delphivcl python libraries and i was so amazed(i liked vcl a lot then), so i started to use it for my hobby project...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
i added support for unicode filenames for Form.LoadProps() methods.
Initially I thought it would be short and simple, but correct work with unicode and filesystem has its quirks.
Also be conforming to python PEPs added some work.
Since there are a lot of possible exceptions and errors, i also extended support for unicode exceptions somewhat. The additional features are:
Note: I want to apologize beforehand - im not delphi pro, last time i worked more with delphi was 25yrs ago, so i want to apologize for the stupid stuff i may have made. However sometime ago i accidentaly found delphifmx and delphivcl python libraries and i was so amazed(i liked vcl a lot then), so i started to use it for my hobby project...