add logging of exceptions during runtime environment create - #20
Merged
dominikschubert merged 2 commits intoJun 5, 2023
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Context
|
Sorry, something went wrong.
joe4dev
approved these changes
May 31, 2023
joe4dev
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM 👍
Fixed in joint session with @dominikschubert and @dfangl
Sorry, something went wrong.
dfangl
approved these changes
May 31, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Assignees
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoids the Runtime Handler can only error while starting error logs in localstack when the invocation fails due to an error.
Previously it caused two "error reports", one via /invocations/<invokeid>/error and one via /status/<runtimeid>/<status>.