FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Change mode of bootstrap file to 0755 if not executable by dfangl · Pull Request #21 · localstack/lambda-runtime-init · GitHub

Change mode of bootstrap file to 0755 if not executable - #21

Merged
dfangl merged 1 commit into
localstackfrom
set-bootstrap-executable
Jul 6, 2023
Merged

Change mode of bootstrap file to 0755 if not executable#21
dfangl merged 1 commit into
localstackfrom
set-bootstrap-executable

Conversation

dfangl commented Jul 6, 2023

Copy link
Copy Markdown
Member

Motivation

This should resolve Permission denied errors we were seeing when people, most notably on non-unix platforms, uploaded lambda zip files without executable permissions on the bootstrap file.

Changes

  • If a bootstrap file (no distinction which, but the default ones in the image should always be executable) is not executable, it will set the permissions to 755, to ensure it executable under all users. If this is not possible, it will log a warning.

dfangl requested a review from dominikschubert July 6, 2023 15:28

dominikschubert left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

dfangl merged commit e4d28d8 into localstack Jul 6, 2023
dfangl deleted the set-bootstrap-executable branch July 6, 2023 19:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants


Back | FazBrowse Home | New Git URL