Fix oversized response handling - #33
Merged
dominikschubert merged 4 commits intoFeb 13, 2024
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
1 task
dfangl
approved these changes
Feb 13, 2024
dfangl
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Looks good in principal, just minor nits
Sorry, something went wrong.
Comment thread
cmd/localstack/custom_interop.go
Comment thread
cmd/localstack/main.go
Comment thread
debugging/Makefile
Outdated
Comment thread
lambda/core/directinvoke/directinvoke.go
joe4dev
reviewed
Feb 13, 2024
joe4dev
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
🚀
Sorry, something went wrong.
Comment thread
cmd/localstack/main.go
Comment thread
cmd/localstack/main.go
| User: GetenvWithDefault("LOCALSTACK_USER", "sbx_user1051"), | ||
| InitLogLevel: GetenvWithDefault("LOCALSTACK_INIT_LOG_LEVEL", "warn"), | ||
| EdgePort: GetenvWithDefault("EDGE_PORT", "4566"), | ||
| MaxPayloadSize: GetenvWithDefault("LOCALSTACK_MAX_PAYLOAD_SIZE", "6291556"), |
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Intentionally no unit _BYTES vs. LAMBDA_LIMITS_MAX_FUNCTION_PAYLOAD_SIZE_BYTES in LocalStack
guess to match with interop.MaxPayloadSize
(LOCALSTACK_POST_INVOKE_WAIT_MS also has a unit)
Sorry, something went wrong.
Comment thread
lambda/interop/model.go
| log "github.com/sirupsen/logrus" | ||
| ) | ||
|
|
||
| var MaxPayloadSize int = 6*1024*1024 + 100 // 6 MiB + 100 bytes |
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
annoying that we cannot use a single type due to mixed usages 😢 (server.go requires an int; not int64)
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Assignees
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When sending an oversized (>6MB) response payload, the runtime process exits with exit code 1. In our error handling code we used log.Fatal when handling a ErrInvokeDoneFailed exception which caused the init to prematurely exit and thus didn't send a proper response back to localstack.
Additionaly when testing, I've noticed a small parity gap, so I patched the generated message to not include the actual bytes there. Though I guess its debatable if we want to keep that part of the PR or not. 🤷♂️