Allow LocalStack specific configuration of chmod on startup, remove DNS logic - #34
Merged
dfangl merged 4 commits intoMar 12, 2024
Merged
Allow LocalStack specific configuration of chmod on startup, remove DNS logic#34dfangl merged 4 commits into
dfangl merged 4 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
joe4dev
approved these changes
Mar 12, 2024
joe4dev
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Nice init improvements 👏👏
- The configurable chmod paths give us more flexibility on the LocalStack side with a sensible noops default [] 👍
- Good to get the DNS cleanup done 🧹
✅ Tested with the LocalStack changes on macOS using:
- tests.aws.services.lambda_.test_lambda.TestLambdaBehavior.test_runtime_introspection_x86 (with + without pre-building)
- tests.aws.services.lambda_.test_lambda.TestLambdaBehavior.test_runtime_introspection_arm
- tests.aws.services.lambda_.test_lambda_developer_tools.TestHotReloading.test_hot_reloading (requires longer sleep on macOS)
- tests.aws.services.lambda_.test_lambda.TestLambdaBehavior.test_lambda_init_environment => requires extra snapshot verify skip for "$..Payload.environment.LOCALSTACK_CHMOD_PATHS",
I didn't test the K8 part.
(For local RIE testing, I had to change the init version back to v0.1.27-pre such that the installer does not fail.)
Sorry, something went wrong.
Comment thread
cmd/localstack/file_utils.go
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
DNS
The DNS rewrite logic was inactive since localstack/localstack-ext#2029.
With the removal we save binary space and reduce code complexity.
File system permissions
The approach to run chmod on /var/task, /tmp and /opt (even though some of them are conditional) taken with #27 has some issues, especially for startup performance with prebuild lambda images. Since with chmod, all the files in the directories (which change) will need to be copied into the upper layer in overlay2, this operation can take an significant amount of time to complete, which will reduce startup time drastically.
We should let LocalStack decide when to apply this logic, and when we can avoid it.
Changes