Add a hot reloading RIE side implementation - #7
Merged
dfangl merged 6 commits intoDec 13, 2022
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
dominikschubert
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Looking forward to this feature! 😁
Added a few nits and suggestions.
Especially the main logic block in RunFileWatcher would benefit a lot from deconstructing it into smaller functions and introducing a struct for the filewatcher.
A few other suggestions for now:
- separate the debounce from the actual consumption/processing of the changes for more clarity (e.g. the debounce itself could be a wrapper around the channel)
- prefer passing a context instead of a channel for signaling exit/done
Sorry, something went wrong.
Comment thread
cmd/localstack/filenotify/filenotify.go
Outdated
Comment thread
cmd/localstack/awsutil.go
Outdated
Comment thread
cmd/localstack/awsutil.go
Outdated
dominikschubert
self-requested a review
December 13, 2022 09:19
dominikschubert
approved these changes
Dec 13, 2022
dominikschubert
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
small nit/suggestion, otherwise LGTM
Sorry, something went wrong.
Comment thread
cmd/localstack/awsutil.go
Outdated
Comment thread
cmd/localstack/awsutil.go
Outdated
Comment thread
cmd/localstack/awsutil.go
Comment thread
cmd/localstack/awsutil.go
Outdated
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
We want to provide hot reloading to be able to mount a volume into the container and see changes as they happen. For this, once a change happens, we have to reset the infrastructure, to support reloading (for example, a loaded python module will not change if the source changes, we have to reload it / restart the interpreter).
Changes
Todos