FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

upgrade go to 1.26 by carole-lavillonniere · Pull Request #80 · localstack/lambda-runtime-init · GitHub

/ lambda-runtime-init Public
forked from aws/aws-lambda-runtime-interface-emulator

upgrade go to 1.26 - #80

Merged
carole-lavillonniere merged 1 commit into
localstackfrom
carole/drg-542
Feb 23, 2026
ConversationCommits (1)ChecksFiles changed
Merged

upgrade go to 1.26#80
carole-lavillonniere merged 1 commit into
localstackfrom
carole/drg-542

Conversation

carole-lavillonniere commented Feb 23, 2026

Copy link
Copy Markdown

... in order to fix vulnerability issues in lambda images https://github.com/localstack/lambda-images

carole-lavillonniere marked this pull request as ready for review February 23, 2026 08:39
joe4dev approved these changes Feb 23, 2026
View reviewed changes

joe4dev left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

nit: Can we add a Linear ticket reference?
It should work as discussed in #tool-linear

gregfurman previously requested changes Feb 23, 2026
View reviewed changes

gregfurman left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Nice! We should probably align the debugging image to match 1.26 as well

lambda-runtime-init/debugging/Makefile

Lines 1 to 2 in 0a1f9b9

# Golang EOL overview: https://endoflife.date/go
DOCKER_GOLANG_IMAGE ?= golang:1.25-bookworm

carole-lavillonniere commented Feb 23, 2026

Copy link
Copy Markdown
Author

Nice! We should probably align the debugging image to match 1.26 as well

lambda-runtime-init/debugging/Makefile

Lines 1 to 2 in 0a1f9b9

# Golang EOL overview: https://endoflife.date/go
DOCKER_GOLANG_IMAGE ?= golang:1.25-bookworm

I already updated that line to 1.26, am I missing something here?

gregfurman commented Feb 23, 2026

Copy link
Copy Markdown

@carole-lavillonniere You're correct 🤦 I misread the diff. LGTM!

gregfurman dismissed their stale review February 23, 2026 12:09

Need a stronger lens prescription for my glasses since I missed my concern was already addressed.

carole-lavillonniere merged commit 6823a17 into localstack Feb 23, 2026
2 checks passed
carole-lavillonniere deleted the carole/drg-542 branch February 23, 2026 12:17
joe4dev mentioned this pull request Apr 3, 2026
Merged
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

joe4dev joe4dev approved these changes
dfangl Awaiting requested review from dfangl dfangl is a code owner
dominikschubert Awaiting requested review from dominikschubert dominikschubert is a code owner
+1 more reviewer
gregfurman gregfurman left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL