fix: HOME fallback for custom container user - #88
Merged
anisaoshafi merged 2 commits intoMar 31, 2026
Merged
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
anisaoshafi
commented
Mar 30, 2026
Comment thread
test-homedir.md
Outdated
anisaoshafi
marked this pull request as ready for review
March 31, 2026 14:03
anisaoshafi
requested review from
dfangl,
dominikschubert and
joe4dev
as code owners
March 31, 2026 14:03
dfangl
approved these changes
Mar 31, 2026
dfangl
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
I think this is a sensible workaround! Where possible, we should try to actually set the right user id and home directory (sbx_user1051), however in cases where we cannot influence the user, it makes sense to have this fallback.
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
When a container starts with --user=1000:1000, AddUser is never called so there is no /etc/passwd entry. Combined with UnsetLsEnvs stripping HOME, Node's os.homedir() and AWS SDK config loading throw ENOENT.
Changes
EnsureHome() runs once at startup after UnsetLsEnvs. If user.Current() fails (no passwd entry), it sets HOME=/tmp. The normal root-start flow is unaffected.
Testing
See test-homedir.md (will be removed) for a manual end-to-end test using a Node.js 22 function that calls os.homedir() with --user=1000:1000.
Towards DRG-715