Add integration attributes to sdk - #26
Merged
alexs-mparticle merged 2 commits intoJun 20, 2023
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
v-mamaya
marked this pull request as ready for review
June 15, 2023 18:25
Copy link
Copy Markdown
Contributor
Author
|
hey @alexs-mparticle, can you take a look and let me know if we should change something? |
Sorry, something went wrong.
alexs-mparticle
requested changes
Jun 20, 2023
alexs-mparticle
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Looks good. Only one style issue. I can release this once the change is made.
Sorry, something went wrong.
Comment thread
example_usage.py
Outdated
Co-authored-by: Alex S <49695018+alexs-mparticle@users.noreply.github.com>
alexs-mparticle
approved these changes
Jun 20, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Added support for integration attributes in case they are needed to be included using the Python SDK
Testing Plan