OpenAPI spec: 6.1.5 review fixes that missed PR #108 - #112
Open
dennisdornon wants to merge 2 commits into
Open
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Remove the unreleased GET /jobs/{id} route and point queued-work status
at the mainwp/get-batch-job-status-v1 ability; document POST/PUT/PATCH
on the SSL Monitor, Domain Monitor, and Lighthouse action routes; add
the widgets, pagespeed, and multi-tokens Pro Reports data sets, make
the date range optional with its one-year default, and model the
multi_tokens template parameter; widen success to [0, 1] only on the
envelopes whose handlers return 0 inside HTTP 200; correct ToolJobStatus
error and timestamp types; replace the fictional 403 responses with the
401 the auth layer actually returns. Same corrections applied to the
extensions.mdx route tables.
…rding Bump the spec's info.version from the stale 6.1.3 to the released 6.1.5. Allow null in ToolJobStatus started_at and completed_at: the disconnect status handler reads a never-written started_at directly and falls back to null for completed_at while the job runs, unlike the empty-string fallback on the destroy and renew routes. Reword the queued-work notes: the batch-status ability is served over the WordPress Abilities API with WordPress authentication, so only a MainWP REST v2 route is missing, not a REST endpoint altogether.
Copy link
Copy Markdown
Contributor
|
Preview deployment for your docs. Learn more about Mintlify Previews.
|
Sorry, something went wrong.
Copy link
Copy Markdown
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: b6cbd3a3-aff4-4578-9485-c10fe079214a 📥 CommitsReviewing files that changed from the base of the PR and between 95fa17a and b6186bc. 📒 Files selected for processing (2)
WalkthroughThe REST API extension documentation now lists additional monitor methods, optional Pro Reports date parameters with a last-year default, the multi_tokens parameter, and three new Pro Reports routes. ChangesREST API extension documentation
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested reviewers: bkatusic 🚥 Pre-merge checks | ✅ 5 ✅ Passed checks (5 passed)
Comment @coderabbitai help to get the list of available commands. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #108 merged before its final two review-fix commits landed, so the published spec is missing them. This carries those two commits unchanged:
Files are byte-identical to the reviewed versions on the original branch.
Summary by CodeRabbit