Actionable comments posted: 1

tests/unit/test_workspace_work_item_property_contexts.py (1)

63-114: 🏗️ Heavy lift

Method name/docstring don't match behavior; contexts.create/contexts.delete remain untested.

This test creates a property, updates the default context, and in teardown deletes the property. It never calls client.workspace_work_item_properties.contexts.create(...) or contexts.delete(...), so the two new CRUD endpoints introduced in this PR have no coverage. Either rename to reflect what it does (create-property / update-default-context) or extend it to actually create and delete a non-default context as the docstring claims.

Want me to draft a test that creates a non-default context (with project + work-item-type IDs) and deletes it via contexts.delete?

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@tests/unit/test_workspace_work_item_property_contexts.py` around lines 63 -
114, The test currently only creates a property and updates the default context
but never exercises the new contexts.create and contexts.delete endpoints;
either rename the test to reflect it only updates the default context or extend
it to create and delete a non-default context: call
client.workspace_work_item_properties.contexts.create(workspace_slug, prop.id,
CreateWorkItemPropertyContext(...)) supplying explicit project and work item
type IDs (so applies_to_all_* are false), assert the returned context fields,
then retrieve it via contexts.retrieve, update if needed, and finally call
client.workspace_work_item_properties.contexts.delete(workspace_slug, prop.id,
created_ctx.id) and assert deletion (or that list no longer contains it); update
the test docstring to match the new behavior if you choose to extend rather than
rename.

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@tests/scripts/test_estimates_methods.py`:
- Line 24: The test currently performs a no-op os.getenv("PLANE_ACCESS_TOKEN")
and always initializes the client with only api_key, breaking the "API key or
access token" path; change the setup in tests/scripts/test_estimates_methods.py
to read and use the access token: assign access_token =
os.getenv("PLANE_ACCESS_TOKEN") (or similar), then initialize the client with
the access token when present (e.g., pass access_token or choose between api_key
and access_token) so the test covers the access-token auth path instead of
ignoring the env value.

---

Nitpick comments:
In `@tests/unit/test_workspace_work_item_property_contexts.py`:
- Around line 63-114: The test currently only creates a property and updates the
default context but never exercises the new contexts.create and contexts.delete
endpoints; either rename the test to reflect it only updates the default context
or extend it to create and delete a non-default context: call
client.workspace_work_item_properties.contexts.create(workspace_slug, prop.id,
CreateWorkItemPropertyContext(...)) supplying explicit project and work item
type IDs (so applies_to_all_* are false), assert the returned context fields,
then retrieve it via contexts.retrieve, update if needed, and finally call
client.workspace_work_item_properties.contexts.delete(workspace_slug, prop.id,
created_ctx.id) and assert deletion (or that list no longer contains it); update
the test docstring to match the new behavior if you choose to extend rather than
rename.

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: a9a02852-47c0-4777-86bc-2aa1be2337de

Reviewing files that changed from the base of the PR and between 8e8240d and e7c5ad0.

• README.md
• plane/__init__.py
• plane/api/milestones.py
• plane/api/work_items/base.py
• plane/api/workspace_work_item_properties/base.py
• plane/api/workspace_work_item_properties/contexts.py
• plane/models/__init__.py
• plane/models/milestones.py
• plane/models/work_item_property_configurations.py
• plane/models/work_item_property_context.py
• plane/models/workspaces.py
• pyproject.toml
• tests/scripts/test_archive.py
• tests/scripts/test_cycles.py
• tests/scripts/test_estimates_methods.py
• tests/scripts/test_milestones.py
• tests/scripts/test_work_item_types_and_properties.py
• tests/unit/test_work_item_properties.py
• tests/unit/test_workspace_work_item_property_contexts.py

• plane/api/milestones.py
• plane/models/work_item_property_configurations.py
• plane/api/work_items/base.py