Correct declared Python support and accept the 'id' field - #184
Merged
caglarpir merged 1 commit intoSep 7, 2026
Merged
caglarpir merged 1 commit into
caglarpir merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Two independent metadata/validation fixes.
REQUIRES_PYTHON was ">=3.0", which is not satisfiable: the SDK cannot
run on any Python 3.x below 3.10, because shapely>=2.1.0 (a declared
runtime requirement) itself requires >=3.10. Verified by installing the
built wheel into clean environments: 3.9 fails to resolve, 3.10 installs
and the SDK works end to end against the live API. The SDK's own source
uses no syntax newer than f-strings, so the floor comes from the
dependency set rather than the code. Classifiers updated to match, and
3.13/3.14 added -- both verified working.
'id' was missing from every entity field list, so passing fields=['id']
raised InvalidFieldError even though the Graph API accepts it and every
decoded feature carries an id. Confirmed against the live API for
images, map features and detections:
GET /1933525276802129?fields=id,captured_at
{"id":"1933525276802129","captured_at":1507560881000}
Added to the image, map feature, detection (both variants) and
organization field lists.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two small, independent correctness fixes to declared metadata and field validation.
1. REQUIRES_PYTHON was ">=3.0"
That is not satisfiable. The SDK cannot install on any Python 3.x below 3.10, because shapely>=2.1.0 — a declared runtime requirement — itself requires >=3.10. The constraint comes from the dependency set, not from the code: src/ contains no syntax newer than f-strings (no match, no PEP 604 unions, no walrus).
Verified empirically by installing the built wheel into clean environments and letting pip resolve install_requires:
Set to ">=3.10". Classifiers updated to match — 3.5 through 3.9 removed (none of them can install the package), 3.13 and 3.14 added, both verified.
2. id was rejected as a field
fields=["id"] raised InvalidFieldError, because id was absent from every entity field list — even though the Graph API accepts it and every decoded feature carries an id property. Confirmed against the live API:
GET /1933525276802129?fields=id,captured_at {"id":"1933525276802129","captured_at":1507560881000} GET /498808147909730?fields=id,object_value {"id":"498808147909730","object_value":"object--street-light"}Detections likewise return id. Added to the image, map feature, detection (both variants) and organization lists.
One caveat worth stating: images, map features and detections were each verified against the live API. Organization was not — I could not find an organization ID readable with the public test token. id is universal in the Graph API so it is near-certain to work there too, but I would rather flag it than imply I checked.
Test plan