This repository was archived by the owner on Jan 9, 2019. It is now read-only.
Repository navigation
fix shading of slf4j (#51) - #52
Merged
sandroboehme merged 1 commit intoJun 5, 2014
Merged
sandroboehme merged 1 commit into
sandroboehme merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
The previous shading included slf4j-api and slf4j-simple in the shaded jar. slf4j-simple was intended as a runtime dependency, and thus shouldn't have been included. slf4j-api was intended as an optional non-shaded dependency, and thus shouldn't have been included.
sandroboehme
added a commit
that referenced
this pull request
Jun 5, 2014
fix shading of slf4j (#51)
Copy link
Copy Markdown
Collaborator
|
Thanks David for the explaination and the fix. It's both much appreciated! |
Sorry, something went wrong.
This was referenced Jun 5, 2014
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous shading included slf4j-api and slf4j-simple in the shaded jar.
slf4j-simple was intended as a runtime dependency, and thus shouldn't have been included.
slf4j-api was intended as an optional non-shaded dependency, and thus shouldn't have been included.