| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
|
Now that I am looking at this, I see a bigger problem. Is see few options here:
I am quite short on time and will look into it later, but you could take a shot at this @nmenardg-keeper if you would like :) |
Sorry, something went wrong.
| @@ -1,4 +1,4 @@ | |||
| black==21.11b1 | |||
There was a problem hiding this comment.
We also need to update README file
Sorry, something went wrong.
|
You're making good points here. Thinking about it, here are the options I see:
I'd go with option 3 |
Sorry, something went wrong.
| run: pip install -r ${{ github.action_path }}/requirements.txt | ||
| run: | | ||
| pip install -r requirements.txt # project's dependencies | ||
| pip install -r ${{ github.action_path }}/requirements.txt # linters |
There was a problem hiding this comment.
setup-python's cache argument was expecting a requirements.txt but is not doing the install
See the example in their readme file:
https://github.com/actions/setup-python#caching-packages-dependencies
Sorry, something went wrong.
There was a problem hiding this comment.
yeah, i have noticed this as well. Thanks for the fix
Sorry, something went wrong.
|
Closed by mistake |
Sorry, something went wrong.
| with: | ||
| python-version: "3.8" | ||
| - name: Generate requirements.txt file | ||
| run: | |
There was a problem hiding this comment.
I'm thinking if shouldn't just do this automatically? Check if the requirements file exists (provided by user). If not, install pipenv and generate dependencies.
Sorry, something went wrong.
There was a problem hiding this comment.
If you have time to do that then go ahead, but I don't
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
setup-python action was searching for the requirements.txt file of the linted python project, which in pipenv projects broke the action
and
updated black to get this fix: psf/black#2966