FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Added some content by hamstar · Pull Request #6 · markdown/markdown.github.com · GitHub

  1. markdown
  2. markdown.github.com

Repository navigation

Added some content - #6

Open
hamstar wants to merge 9 commits into
markdown:masterfrom
hamstar:master
ConversationCommits (9)ChecksFiles changed
Open

Added some content#6
hamstar wants to merge 9 commits into
markdown:masterfrom
hamstar:master

Conversation

hamstar commented Nov 26, 2012

Copy link
Copy Markdown

Added some implementations, developers and added another section for libraries that parse markdown.

I also added a favicon (the same as the markdown github repo avatar).

Tested it in jekyll all looks good.

hamstar commented Nov 26, 2012

Copy link
Copy Markdown
Author

I may have mistaken the meaning of implementors...

waylan reviewed Nov 26, 2012
View reviewed changes
Comment thread _layouts/base.html

waylan Nov 26, 2012

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This had a valid html5 doctype. Why should we change this? I see no reason. Both html and xhtml are valid under html5.

davidchambers Nov 26, 2012

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

+1 for sticking with <!DOCTYPE html>.

hamstar Nov 27, 2012

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Ah ok my bad.

waylan commented Nov 26, 2012

Copy link
Copy Markdown
Member

The favicon is nice, but if it comes from Github, do we have permission to use it? I didn't check, maybe it's licenced in an acceptable manner. But I think we should verify that before using it.

davidchambers commented Nov 26, 2012

Copy link
Copy Markdown
Member

The favicon is nice, but if it comes from Github, do we have permission to use it?

I created the icon, so I think we're okay. ;)

hamstar commented Nov 27, 2012

Copy link
Copy Markdown
Author

Dammit why didn't I use topic branches!

hamstar commented Nov 27, 2012

Copy link
Copy Markdown
Author

Unless you guys have a way to pick and choose commits to add, or can do a manual merge/edit/commit/push then reject this pull request and I will submit more coherent content and topic branches.

This branch has not been deployed

No deployments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL