fix:In scenarios involving languages such as Chinese, Japanese, and K… - #73
Open
yayapoi wants to merge 1 commit into
Open
fix:In scenarios involving languages such as Chinese, Japanese, and K…#73yayapoi wants to merge 1 commit into
yayapoi wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
…orean, for instance, when an a.md file contains links to other local md files in the format of [第一章](/第一章/第一章.md), clicking on these links fails to open the local md files normally. However, by converting these languages to UTF-8 encoding, the md files can now be opened without issues
BoosterY
added a commit
to BoosterY/markmap-vscode
that referenced
this pull request
Apr 25, 2026
Markdown-it percent-encodes non-ASCII characters in link hrefs (e.g. Chinese/Japanese/Korean filenames). The openFile handler passed these encoded paths directly to Utils.joinPath, resulting in file-not-found errors. Apply decodeURIComponent before constructing the file URI. Fixes markmap#73
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix:In scenarios involving languages such as Chinese, Japanese, and Korean, for instance, when an a.md file contains links to other local md files in the format of 第一章, clicking on these links fails to open the local md files normally. However, by converting these languages to UTF-8 encoding, the md files can now be opened without issues
