fix: start every scriptlet range at its $ - #244
Merged
DylanPiercey merged 1 commit intoSep 23, 2026
Merged
DylanPiercey merged 1 commit into
DylanPiercey merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Concise content skipped the `$` before entering INLINE_SCRIPT, so a scriptlet at the root or in concise mode started at the space after it, while one in an HTML body started at the `$`. Both now start at the `$`. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Copy link
Copy Markdown
🦋 Changeset detectedLatest commit: 9452de1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Sorry, something went wrong.
Copy link
Copy Markdown
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #244 +/- ##
=======================================
Coverage 99.95% 99.95%
=======================================
Files 34 34
Lines 4576 4576
Branches 879 879
=======================================
Hits 4574 4574
Misses 2 2 ☔ View full report in Codecov by Harness.
|
Sorry, something went wrong.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A scriptlet's range started at its $ inside an HTML body, but at the space after it at the root and in concise content, because CONCISE_HTML_CONTENT skipped the $ before entering INLINE_SCRIPT. It now enters first, as HTML_CONTENT does, so onScriptlet reports $ var a = 1; everywhere. The value range is unchanged; the concise scriptlet snapshots move back one column.
🤖 Generated with Claude Code