Link intel-gcm-* libraries as necessary in static builds of NSS - #92
Merged
martinthomson merged 1 commit intoDec 8, 2025
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
martinthomson
approved these changes
Dec 8, 2025
martinthomson
left a comment
Copy link
Copy Markdown
Owner
There was a problem hiding this comment.
This is good. I made a similar change here, but that is bundled with other updates.
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
@martinthomson Is there any chance you could spin a 0.7.2 release with this change? |
Sorry, something went wrong.
Copy link
Copy Markdown
Owner
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prior to NSS 3.119, static builds of freebl did not use hardware accelerated GCM on x64. We changed that in 3.119, specifically with this patch, so now the ohttp/build.rs script needs to check for and possibly link the intel-gcm-* libraries.