ohttp: build: use proper target OS for bindgen - #98
Conversation
Sorry, something went wrong.
martinthomson
left a comment
There was a problem hiding this comment.
Quite right. Cross compilation support has never been a high priority here; if this is all it takes, then I'm surprised, but pleased.
Sorry, something went wrong.
|
There are other uses of consts::OS in the build script, but I'm not entirely sure whether they're right or not. I know that at least this patch applied to the vendored version in the firefox tree gets the crate to build on my windows-on-mac scenario (which then fails later because of course, that'd be too easy 😉 ). |
Sorry, something went wrong.
When running bindgen, we can't use std::env::consts::OS as it will be the host OS in the build script, rather than the target one. It doesn't matter much for Linux and Windows as the defined constants don't appear to be used anywhere (at least in the Firefox build), the code relying instead on other values such as `__linux__` (compiler-defined) or `XP_WIN`.
|
That last push is just to fix the author info, I had a mishap with my git config. |
Sorry, something went wrong.
|
I took a quick look at the other uses of OS and I think those all relate to local constraints. I could be wrong about some of those, but I'm willing to say that any progress is some progress. |
Sorry, something went wrong.
When running bindgen, we can't use std::env::consts::OS as it will be the host OS in the build script, rather than the target one. It doesn't matter much for Linux and Windows as the defined constants don't appear to be used anywhere (at least in the Firefox build), the code relying instead on other values such as __linux__ (compiler-defined) or XP_WIN.