support double click events - #446
Merged
ianhi merged 2 commits intoMar 31, 2022
Merged
Conversation
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
|
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Author
|
Ok I'm out of ideas for fixing this error: [webpack-cli] Error: error:0308010C:digital envelope routines::unsupported
at new Hash (node:internal/crypto/hash:67:19)
at Object.createHash (node:crypto:130:10)
at BulkUpdateDecorator.hashFactory (/home/runner/work/ipympl/ipympl/node_modules/webpack/lib/util/createHash.js:155:18)
at BulkUpdateDecorator.digest (/home/runner/work/ipympl/ipympl/node_modules/webpack/lib/util/createHash.js:80:21)
at /home/runner/work/ipympl/ipympl/node_modules/webpack/lib/DefinePlugin.js:595:38
at _next31 (eval at create (/home/runner/work/ipympl/ipympl/node_modules/tapable/lib/HookCodeFactory.js:19:10), <anonymous>:42:1)
at _next9 (eval at create (/home/runner/work/ipympl/ipympl/node_modules/tapable/lib/HookCodeFactory.js:19:10), <anonymous>:97:1)
at Hook.eval [as call] (eval at create (/home/runner/work/ipympl/ipympl/node_modules/tapable/lib/HookCodeFactory.js:19:10), <anonymous>:119:1)
at Hook.CALL_DELEGATE [as _call] (/home/runner/work/ipympl/ipympl/node_modules/tapable/lib/Hook.js:14:14)
at Compiler.newCompilation (/home/runner/work/ipympl/ipympl/node_modules/webpack/lib/Compiler.js:1053:26) {
opensslErrorStack: [ 'error:03000086:digital envelope routines::initialization error' ],
library: 'digital envelope routines',
reason: 'unsupported',
code: 'ERR_OSSL_EVP_UNSUPPORTED'
}
@martinRenou any thoughts? Everything on the internet seems to point this being an issue with node 17 but above commits moving to node 16 didn't seem to help :( |
Sorry, something went wrong.
Fixes `ERR_OSSL_EVP_UNSUPPORTED` because openssl 3 no longer provides md4. https://github.com/webpack/webpack/releases/tag/v5.61.0
Copy link
Copy Markdown
Collaborator
Author
|
bumping webpack version was the solution |
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Author
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Sorry I missed your question. I will push a PR for that OpenSSL issue, we fixed it in multiple places. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes: #261 attn @nvaytet
@martinRenou for version numbers what do we do here? I think we need to bump package.json
ipympl/package.json
Line 3 in 21a1c8d
to either 0.11.0 or 0.10.6 and also bump the python version. Is there anything we can do here to ameliorate the patch version incompatibility (#416)?