Build using JupyterLab 4 - #543
Merged
martinRenou merged 2 commits intoJan 26, 2024
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
|
Sorry, something went wrong.
ianthomas23
force-pushed
the
build_using_jlab4
branch
from
c62d4ac to
fadf80f
Compare
January 26, 2024 14:42
Copy link
Copy Markdown
Member
Author
|
I've removed the captions above the Matplotlib figures otherwise slight differences in rendering between ubuntu and macos cause the image comparison tests to fail. These captions are in <div>s anyway rather than generated by Matplotlib. |
Sorry, something went wrong.
martinRenou
approved these changes
Jan 26, 2024
martinRenou
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Thank you!
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #539.
This changes the build system to build against JupyterLab 4 rather than 3. I have manually checked that the wheel generated in this way works on all the following:
Note that ipympl already worked fine on JupyterLab 4, this just modernises the build process.