FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Fix update_galata_references github action by ianthomas23 · Pull Request #545 · matplotlib/ipympl · GitHub

/ ipympl Public

Fix update_galata_references github action - #545

Merged
martinRenou merged 2 commits into
matplotlib:mainfrom
ianthomas23:update_galata_action
Jan 29, 2024
ConversationCommits (2)ChecksFiles changed
Merged

Fix update_galata_references github action#545
martinRenou merged 2 commits into
matplotlib:mainfrom
ianthomas23:update_galata_action

Conversation

ianthomas23 commented Jan 29, 2024

Copy link
Copy Markdown
Member

Here I am trying to fix the update_galata_references github action after the recent changes that broke it. It should be run as before by adding a PR comment containing the text "update galata references". I have checked in a couple of incorrect test images so that the update is required before CI will pass.

This is not yet using the JupyterLab maintainer-tools, that is something to consider in the future.

ianthomas23 commented Jan 29, 2024

Copy link
Copy Markdown
Member Author

Please update galata references.

1 similar comment

ianthomas23 commented Jan 29, 2024

Copy link
Copy Markdown
Member Author

Please update galata references.

ianthomas23 commented Jan 29, 2024

Copy link
Copy Markdown
Member Author

Pretty please update galata references.

ianthomas23 commented Jan 29, 2024

Copy link
Copy Markdown
Member Author

Hmm, it is running the action from the main branch not this PR branch, as it is running code that I have deleted in this branch.

martinRenou commented Jan 29, 2024

Copy link
Copy Markdown
Member

Yep the bot runs from the main branch. Last time I checked, it's not possible for it to run on the branch that originated the PR.

martinRenou approved these changes Jan 29, 2024
View reviewed changes

martinRenou left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thank you! Let's merge and test it

martinRenou merged commit 1d304ac into matplotlib:main Jan 29, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

martinRenou martinRenou approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL