Use correct versioning - #550
Merged
martinRenou merged 1 commit intoMar 15, 2024
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
martinRenou
approved these changes
Mar 15, 2024
martinRenou
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Thanks!
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When I updated the build system to use hatch (#541) I didn't set up the dynamic versioning correctly. This came to light in #549 as currently the package version is 0.9.4.dev1 but ipympl.__version__ is still 0.9.3.
This fixes the dynamic versioning in pyproject.toml so that hatch reads the one-and-only version number from ipympl._version.py.