Update binder2 - #555
Conversation
Sorry, something went wrong.
|
Here is the mybinder link that the README will effectively point to (but it will be on main rather than this PR branch): https://mybinder.org/v2/gh/ianthomas23/ipympl/update-binder2?urlpath=lab/tree/docs/examples/full-example.ipynb. It all seems to work OK. It appears that the binder workflow is using the github action from main rather than this branch so it won't work until this is merged. I am happy to merge and iterate. |
Sorry, something went wrong.
| - numpy | ||
| - yarn~=3.0 | ||
| - jupyterlab~=4.0 | ||
| - retrolab |
There was a problem hiding this comment.
Should we replace this by notebook 7?
Sorry, something went wrong.
| issue_number: context.issue.number, | ||
| owner: context.repo.owner, | ||
| repo: context.repo.repo, | ||
| body: `[](https://mybinder.org/v2/gh/${PR_HEAD_USERREPO}/${PR_HEAD_REF}?urlpath=retro/notebooks/docs/examples/full-example.ipynb) :point_left: Launch a binder notebook on branch _${PR_HEAD_USERREPO}/${PR_HEAD_REF}_` |
There was a problem hiding this comment.
If we use notebook 7, this url could point to notebooks/docs/examples/full-example.ipynb ? (to be verified)
Sorry, something went wrong.
|
Thanks for looking into it! |
Sorry, something went wrong.
martinRenou
left a comment
There was a problem hiding this comment.
Thanks!
Sorry, something went wrong.
Update the binder config, both in the top of the README and in the github actions PR workflow. Take 2.