Repository navigation
backport to 2.x fixes for sphinx 1.8? #13258
Description
Hello,
in Debian we just got this bug report, http://bugs.debian.org/918896:
matplotlib2 fails to build with Sphinx 1.8, currently available in experimental: # build the doc [...] /usr/bin/make -C doc html make[1]: Entering directory '/<<PKGBUILDDIR>>/doc' Running Sphinx v1.8.3 Warning, treated as error: while setting up extension matplotlib.sphinxext.mathmpl: directive u'math' is already registered, it will be overridden make[1]: *** [Makefile:20: html] Error 2 This was fixed in matplotlib 3.x in this commit, please backport it: https://github.com/matplotlib/matplotlib/commit/f87e9f46daf42ad7 That commit switches from generating PNG images for math formulas to MathJax library, which renders the math formulas on client side. To package it for Debian, please add this line to conf.py: mathjax_path = 'file:///usr/share/javascript/mathjax/MathJax.js?config=TeX-AMS-MML_HTMLorMML' and make your documentation package depend on libjs-mathjax. Also upstream has noticed that some math renders incorrectly with MathJax, there is a follow-up commit which fixes it: https://github.com/matplotlib/matplotlib/commit/a101de79650e077a
i see an issue was already reported and fixed at #12108 but it looks like the fixes where never backported to 2.x - would it be possible to do that?
thanks!
Activity
NelleV commented on Jan 22, 2019
Sure thing!
NelleV commented on Jan 22, 2019
I believe it already has been. This patch is fully in our branch already.
dstansby commented on Jan 24, 2019
I'm going to close this since it looks like it's fixed - feel free to comment or re-open if I'm wrong!
LocutusOfBorg commented on Jan 30, 2019
Hello, can we please have a backport against 2.2.x branch?
tacaswell commented on Feb 1, 2019
It looks like this got pulled back to 3.0.x and 3.0.0-doc, but not the 2.2.x branches.
I think we need to backport both #12149 and #11928
tacaswell commented on Feb 1, 2019
Tried to do this naively, did not work, do not have time to dig deeper now.
tacaswell commented on Feb 12, 2019
Closed by #13420
LocutusOfBorg commented on Feb 12, 2019
thanks! I will test it in a few minutes
sandrotosi commented on Feb 12, 2019
@LocutusOfBorg i'm already working on it, please leave the package maintainer job to the package maintainer
LocutusOfBorg commented on Feb 12, 2019
@sandrotosi I'll leave happily to you the Debian part :)
I want to take care of the Ubuntu part, and Ubuntu is going to freeze really soon and matplotlib2 never reached any stable Ubuntu release.
LocutusOfBorg commented on Feb 12, 2019
(btw without manual intervention the package won't probably be ever autosyncd, because it has been removed from Ubuntu due to sphinx 1.8)
sandrotosi commented on Feb 12, 2019
the PR patch (applied directly on top of 2.2.3) works, thanks!
tacaswell commented on Feb 13, 2019
There should be a 2.2.4 in the next few days as well.