FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Mathtext tutorial fixes by anntzer · Pull Request #12149 · matplotlib/matplotlib · GitHub

  1. matplotlib
  2. matplotlib

Repository navigation

Mathtext tutorial fixes - #12149

Merged
jklymak merged 4 commits into
matplotlib:masterfrom
anntzer:mathtext-tut
Oct 4, 2018
ConversationCommits (4)ChecksFiles changed
Merged

Mathtext tutorial fixes#12149
jklymak merged 4 commits into
matplotlib:masterfrom
anntzer:mathtext-tut

Conversation

anntzer commented Sep 18, 2018

Copy link
Copy Markdown
Contributor

PR Summary

  • First commit removes a reference to (obsolete) narrow python builds and adds quotes to an example string.
  • Second commit switches the format of the tutorial from half-docstring, half-comments to a single large docstring (there isn't really a reason to split it and I find the different highlighting a bit jarring) and reflows it to 79 characters wide.

I'd suggest reviewing the two commits separately :p

Preliminary work to a proper fix of #12108 / #12128

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

anntzer force-pushed the mathtext-tut branch 2 times, most recently from fc588cc to b15a24e Compare September 18, 2018 10:09
NelleV reviewed Sep 18, 2018
View reviewed changes

NelleV left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM 👍
I've added some oxford commas and capitalization of Matplotlib. Will merge once the CI passes!

anntzer commented Sep 18, 2018

Copy link
Copy Markdown
Contributor Author

yay, to, oxford, commas,

timhoffm reviewed Sep 18, 2018
View reviewed changes
Comment thread tutorials/text/mathtext.py Outdated
-----------------------------------------

Fractions, binomials and stacked numbers can be created with the ``\frac{}{}``,
Fractions, binomials, and stacked numbers can be created with the ``\frac{}{}``,

timhoffm Sep 18, 2018

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Line too long with the comma 😄

NelleV Sep 18, 2018

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I'm now wondering if I should use the github interface or give up on being lazy and clone the code…

NelleV Sep 18, 2018

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

decision postponed after the coffee break ☕

anntzer Oct 4, 2018

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

fixed

tacaswell added this to the v3.0.0-doc milestone Sep 19, 2018
anntzer and others added 4 commits October 4, 2018 15:31
Minor fixes to mathtext tutorial.
0ce42a6 
- Remove reference to (obsolete) narrow python builds.
- Quote a string.
Reflow the mathtext tutorial.
6d15d93 
- Switch from part-string, part-comment to a single large string.
- Reflow to 79 characters wide.
DOC oxford commas and capitalization.
10dc86c
Rewrap overly long line.
11d0376
jklymak merged commit 2c1a064 into matplotlib:master Oct 4, 2018
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Oct 4, 2018
Backport PR matplotlib#12149: Mathtext tutorial fixes
8c58f4e
meeseeksmachine mentioned this pull request Oct 4, 2018
Merged
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Oct 4, 2018
Backport PR matplotlib#12149: Mathtext tutorial fixes
e795a40
meeseeksmachine mentioned this pull request Oct 4, 2018
Merged
anntzer deleted the mathtext-tut branch October 4, 2018 20:31
jklymak added a commit that referenced this pull request Oct 4, 2018
Merge pull request #12403 from meeseeksmachine/auto-backport-of-pr-12…
2765efb 
…149-on-v3.0.x

Backport PR #12149 on branch v3.0.x (Mathtext tutorial fixes)
jklymak added a commit that referenced this pull request Oct 5, 2018
Merge pull request #12404 from meeseeksmachine/auto-backport-of-pr-12…
afc4375 
…149-on-v3.0.0-doc

Backport PR #12149 on branch v3.0.0-doc (Mathtext tutorial fixes)
tacaswell mentioned this pull request Feb 1, 2019
Closed
tacaswell pushed a commit to tacaswell/matplotlib that referenced this pull request Feb 12, 2019
Merge pull request matplotlib#12149 from anntzer/mathtext-tut
c11eefd 
Mathtext tutorial fixes

Conflicts:
	.flake8
          - does not exist on this branch
	tutorials/text/mathtext.py
          - keep all backported changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

NelleV NelleV approved these changes
timhoffm timhoffm left review comments

Assignees

No one assigned

Labels

Documentation

Projects

None yet

Milestone

v3.0.0-doc

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL